Bug 165714

Summary: WebAssembly: test throwing out of the start function
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ggaren, jfbastien, keith_miller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165150    
Bug Blocks: 161709    
Attachments:
Description Flags
patch
keith_miller: review+, keith_miller: commit-queue-
patch
none
patch
buildbot: commit-queue-
patch none

JF Bastien
Reported 2016-12-09 19:09:44 PST
.
Attachments
patch (4.30 KB, patch)
2017-07-26 10:10 PDT, JF Bastien 		keith_miller: review+
keith_miller: commit-queue-
DetailsFormatted DiffDiff
patch (5.78 KB, patch)
2017-07-26 14:47 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (9.31 KB, patch)
2017-07-26 14:55 PDT, JF Bastien 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch (9.31 KB, patch)
2017-07-26 15:51 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-20 14:26:10 PST
<rdar://problem/29760251>
JF Bastien
Comment 2 2017-07-26 10:10:51 PDT
Created attachment 316452 [details] patch
Keith Miller
Comment 3 2017-07-26 10:13:12 PDT
Comment on attachment 316452 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=316452&action=review r=me with comment. > JSTests/wasm/function-tests/trap-from-start.js:48 > + assert.throws(() => new WebAssembly.Instance(module, imp), WebAssembly.RuntimeError, `Out of bounds memory access`); Can we also get a version of this with instantiate?
JF Bastien
Comment 4 2017-07-26 14:47:58 PDT
Created attachment 316484 [details] patch Add async test.
JF Bastien
Comment 5 2017-07-26 14:55:33 PDT
Created attachment 316486 [details] patch Forgot a file.
Build Bot
Comment 6 2017-07-26 15:39:45 PDT
Comment on attachment 316486 [details] patch Attachment 316486 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/4192723 New failing tests: wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-cjit-yes-tls-context
JF Bastien
Comment 7 2017-07-26 15:51:18 PDT
Created attachment 316492 [details] patch Add back inadvertently removed `new`.
WebKit Commit Bot
Comment 8 2017-07-26 16:29:28 PDT
Comment on attachment 316492 [details] patch Clearing flags on attachment: 316492 Committed r219969: <http://trac.webkit.org/changeset/219969>
WebKit Commit Bot
Comment 9 2017-07-26 16:29:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.