Bug 164419

Summary: Add layout test for input.setCustomValidity()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164382    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-11-04 12:01:43 PDT
Add layout test for input.setCustomValidity().
Attachments
Patch (3.39 KB, patch)
2016-11-04 12:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2016-11-04 12:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.05 KB, patch)
2016-11-04 13:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-11-04 12:06:09 PDT
Created attachment 293906 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-11-04 12:10:04 PDT
Comment on attachment 293906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293906&action=review > LayoutTests/fast/forms/validation-custom-message.html:16 > + uiController.uiScriptComplete(JSON.stringify(uiController.contentsOfUserInterfaceItem('validationBubble'))); I don't think you need to call uiController.uiScriptComplete() to get the result through. Does it work if you just return the result from this function?
Chris Dumez
Comment 3 2016-11-04 12:15:03 PDT
Created attachment 293910 [details] Patch
Chris Dumez
Comment 4 2016-11-04 13:01:59 PDT
Comment on attachment 293910 [details] Patch Forgot to skip the new test on WK1. Will do this before landing.
Chris Dumez
Comment 5 2016-11-04 13:03:43 PDT
Created attachment 293916 [details] Patch
WebKit Commit Bot
Comment 6 2016-11-04 13:51:17 PDT
Comment on attachment 293916 [details] Patch Clearing flags on attachment: 293916 Committed r208397: <http://trac.webkit.org/changeset/208397>
WebKit Commit Bot
Comment 7 2016-11-04 13:51:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.