Bug 164383

Summary:

IndexedDB 2.0: Rename IDBKeyRange.contains to IDBKeyRange.includes

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, alecflett, bdakin, buildbot, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

160306

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Patch	none

Brady Eidson

Reported 2016-11-03 16:13:54 PDT

IndexedDB 2.0: Rename IDBKeyRange.contains to IDBKeyRange.includes "contains" was an old iteration of this API. Per http://w3c.github.io/IndexedDB/#keyrange it's now "includes"

Attachments
Patch (11.10 KB, patch) 2016-11-03 16:16 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (961.42 KB, application/zip) 2016-11-03 17:16 PDT, Build Bot	no flags	Details
Patch (41.31 KB, patch) 2016-11-03 17:24 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-11-03 16:16:08 PDT

Created attachment 293817 [details] Patch

Build Bot

Comment 2 2016-11-03 17:16:02 PDT

Comment on attachment 293817 [details] Patch Attachment 293817 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2457201 New failing tests: storage/indexeddb/keyrange.html storage/indexeddb/keyrange-private.html

Build Bot

Comment 3 2016-11-03 17:16:06 PDT

Created attachment 293831 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Brady Eidson

Comment 4 2016-11-03 17:24:03 PDT

Created attachment 293832 [details] Patch

WebKit Commit Bot

Comment 5 2016-11-03 18:11:28 PDT

The commit-queue encountered the following flaky tests while processing attachment 293832 [details]: webaudio/audiobuffersource-playbackrate.html bug 164393 (authors: crogers@google.com, haraken@chromium.org, and sam@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 6 2016-11-03 18:11:54 PDT

Comment on attachment 293832 [details] Patch Clearing flags on attachment: 293832 Committed r208359: <http://trac.webkit.org/changeset/208359>

WebKit Commit Bot

Comment 7 2016-11-03 18:11:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.