Bug 164332

Summary: Give IDBKey(Data) a WTF::Variant overhaul
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, darin, jsbell, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2 none

Brady Eidson
Reported 2016-11-02 12:39:31 PDT
Give IDBKey(Data) a WTF::Variant overhaul
Attachments
Patch (20.57 KB, patch)
2016-11-02 14:39 PDT, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.51 MB, application/zip)
2016-11-02 15:43 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-11-02 14:39:32 PDT
Created attachment 293697 [details] Patch
Alex Christensen
Comment 2 2016-11-02 14:50:20 PDT
Comment on attachment 293697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293697&action=review > Source/WebCore/Modules/indexeddb/IDBKey.cpp:39 > +IDBKey::IDBKey() > + : m_type(KeyType::Invalid) > + , m_sizeEstimate(OverheadSize) > +{ > +} This should just use initializer lists in the header.
Andy Estes
Comment 3 2016-11-02 14:56:10 PDT
Comment on attachment 293697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293697&action=review > Source/WebCore/Modules/indexeddb/IDBKey.cpp:89 > + const auto& array = WTF::get<Vector<RefPtr<IDBKey>>>(m_value); > + const auto& otherArray = WTF::get<Vector<RefPtr<IDBKey>>>(other.m_value); Vector<RefPtr<IDBKey>> could benefit from a type alias. I would omit the const here, but I don't feel strongly about that. You added similar code below (in IDBKeyData.cpp) that omits const, so maybe at least be consistent. > Source/WebCore/Modules/indexeddb/IDBKey.cpp:105 > + double number = WTF::get<double>(m_value); > + double otherNumber = WTF::get<double>(other.m_value); I'd use auto here.
Build Bot
Comment 4 2016-11-02 15:43:13 PDT
Comment on attachment 293697 [details] Patch Attachment 293697 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2452648 New failing tests: svg/wicd/test-rightsizing-b.xhtml
Build Bot
Comment 5 2016-11-02 15:43:16 PDT
Created attachment 293702 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Brady Eidson
Comment 6 2016-11-02 16:07:53 PDT
https://trac.webkit.org/changeset/208310
Brady Eidson
Comment 7 2016-11-02 16:08:53 PDT
(In reply to comment #4) > Comment on attachment 293697 [details] > Patch > > Attachment 293697 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/2452648 > > New failing tests: > svg/wicd/test-rightsizing-b.xhtml This failure has nothing to do with this patch.
Note You need to log in before you can comment on or make changes to this bug.