Bug 16214

Summary:

rename KURL to URL

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Platform

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

abarth, ap, darin, sam, timothy, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

37641

Attachments:

Description	Flags
patch for scrubbing URL out of the tree (step 1)	none
newer URL -> url patch	none
newer URL -> url patch (now with Windows support and changelogs)	none
Patch	kling: review+, buildbot: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	kling: review+

Darin Adler

Reported 2007-11-30 17:25:22 PST

Going to do it.

Attachments
patch for scrubbing URL out of the tree (step 1) (129.33 KB, patch) 2007-11-30 17:25 PST, Darin Adler	no flags	Details Formatted Diff Diff
newer URL -> url patch (129.44 KB, patch) 2007-12-10 14:44 PST, Darin Adler	no flags	Details Formatted Diff Diff
newer URL -> url patch (now with Windows support and changelogs) (157.78 KB, patch) 2007-12-10 21:47 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (1.52 MB, patch) 2013-09-26 22:42 PDT, Darin Adler	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Patch (1.36 MB, patch) 2013-09-27 07:25 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (1.38 MB, patch) 2013-09-27 07:30 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (1.38 MB, patch) 2013-09-27 07:40 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (1.52 MB, patch) 2013-09-27 07:55 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (1.52 MB, patch) 2013-09-27 08:20 PDT, Darin Adler	kling: review+	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2007-11-30 17:25:51 PST

Created attachment 17616 [details] patch for scrubbing URL out of the tree (step 1)

Darin Adler

Comment 2 2007-12-10 14:44:02 PST

Created attachment 17828 [details] newer URL -> url patch

Sam Weinig

Comment 3 2007-12-10 21:47:39 PST

Created attachment 17837 [details] newer URL -> url patch (now with Windows support and changelogs)

Darin Adler

Comment 4 2007-12-11 16:00:06 PST

Comment on attachment 17837 [details] newer URL -> url patch (now with Windows support and changelogs) + Scrub URL out of the tree in preparation of ranameing KURL to URL. Renaming is spelled wrong here. Also "in preparation of" is not very good English. + * WebCore.base.exp: + * bindings/js/kjs_events.cpp: + (WebCore::JSLazyEventListener::parseCode): I don't think it is all that helpful to list all the files and functions when the only change is renaming. It would be neat to list only files that have interesting changes; something other than just renaming. Or we could just omit the file list entirely. Or leave it as is, not sure. 1637 DeprecatedString dstUrl = activeFrame->loader()->completeURL(DeprecatedString(args[0]->toString(exec))).url(); 1637 String dstUrl = activeFrame->loader()->completeURL(args[0]->toString(exec)).deprecatedString(); This is strange. It's changed to call deprecatedString(), but the type of the variable was changed to String! 48 return m_url.url().isNull(); 48 return m_url.deprecatedString().isNull(); We should probably add a KURL.isNull() for this. Not sure why I didn't. What about platforms other than Mac and Windows. r=me if you fix the things I mentioned above.

Sam Weinig

Comment 5 2007-12-11 23:34:07 PST

Comment on attachment 17837 [details] newer URL -> url patch (now with Windows support and changelogs) First patch landed in r28639. Removing the review flag to continue using this bug.

Geoffrey Garen

Comment 6 2007-12-11 23:36:01 PST

I thought we wanted to rename KURL to DeprecatedURL or ParsedURL, not URL, right? URL gives the incorrect impression that this is the class that you should use when passing around URLs when, in reality, a String is just fine in many cases. Also, KURL is built on top of DeprecatedString.

Darin Adler

Comment 7 2007-12-12 07:46:46 PST

(In reply to comment #6) > I thought we wanted to rename KURL to DeprecatedURL or ParsedURL, not URL, > right? I discussed this at length with Maciej and a few others. I can't remember all the arguments back and forth but we did settle on URL. > URL gives the incorrect impression that this is the class that you should use > when passing around URLs when, in reality, a String is just fine in many cases. That's true. But URL provides some benefits. I really wish I could remember the details of the discussion. I thought you were involved. > Also, KURL is built on top of DeprecatedString. That's temporary. We will be changing that.

Adam Barth

Comment 8 2011-12-21 23:53:49 PST

> > URL gives the incorrect impression that this is the class that you should use > > when passing around URLs when, in reality, a String is just fine in many cases. > > That's true. But URL provides some benefits. I really wish I could remember the details of the discussion. I thought you were involved. In the past, we've talked about having a URLString class for passing around Strings that are URLs (i.e., that have already been validated as URLs).

Darin Adler

Comment 9 2013-09-26 22:42:48 PDT

Created attachment 212788 [details] Patch

Build Bot

Comment 10 2013-09-27 03:02:23 PDT

Comment on attachment 212788 [details] Patch Attachment 212788 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/2655100

Andreas Kling

Comment 11 2013-09-27 07:25:04 PDT

Created attachment 212806 [details] Patch

Andreas Kling

Comment 12 2013-09-27 07:30:12 PDT

Created attachment 212807 [details] Patch Oops, didn't get Tools/