Bug 162033

Created attachment 289000 [details] Patch

Attachment 289000 [details] did not pass style-queue: ERROR: Source/WebCore/css/StyleColor.h:41: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/css/StyleColor.h:42: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/css/CSSFunctionValue.cpp:50: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/CSSFunctionValue.cpp:51: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/CSSFunctionValue.h:63: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/css/CSSFunctionValue.h:69: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:492: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:551: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:747: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/CSSProperty.cpp:161: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserIdioms.cpp:55: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserIdioms.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 12 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 289001 [details] Patch

Attachment 289001 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:551: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 289001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289001&action=review > Source/WebCore/css/CSSValueKeywords.in:1157 > +paint Do we support this one yet? > Source/WebCore/css/parser/CSSParserFastPaths.cpp:179 > - case CSSPropertyTextDecorationColor: > + case CSSPropertyWebkitTextDecorationColor: Is this because we don't support the unprefixed form? > Source/WebCore/css/parser/CSSParserFastPaths.cpp:537 > - return valueID == CSSValueAuto || valueID == CSSValueSRGB || valueID == CSSValueLinearRGB; > + return valueID == CSSValueAuto || valueID == CSSValueSrgb || valueID == CSSValueLinearrgb; We should add a parameter to CSSValueKeywords.in that allows us to map things to nicer names. CSSPropertyNames.in has something like this: some-name-with-a-tla [NameForMethods=SomeNameWithATLA]

Landed in r206007.