Bug 156911

Summary: [Fetch API] FetchResponse should return a ReadableStream even if disturbed
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151937    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-04-22 07:33:19 PDT
As per the specification, FetchResponse body should be a ReadableStream even if disturbed. Currently, body is null if body is consumed.
Attachments
Patch (7.21 KB, patch)
2016-04-22 07:42 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.29 KB, patch)
2016-04-28 23:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-04-22 07:42:29 PDT
Created attachment 277060 [details] Patch
Darin Adler
Comment 2 2016-04-22 17:10:45 PDT
Comment on attachment 277060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277060&action=review > Source/WebCore/Modules/fetch/FetchResponse.cpp:296 > + ASSERT(!FetchBodyOwner::isDisturbed()); Why not just ASSERT(!isDisturbed())?
youenn fablet
Comment 3 2016-04-24 04:57:01 PDT
Thanks for the review. (In reply to comment #2) > Comment on attachment 277060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277060&action=review > > > Source/WebCore/Modules/fetch/FetchResponse.cpp:296 > > + ASSERT(!FetchBodyOwner::isDisturbed()); > > Why not just ASSERT(!isDisturbed())? Right, this is only an ASSERT. I'll update the patch accordingly.
youenn fablet
Comment 4 2016-04-28 23:37:09 PDT
Created attachment 277677 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-04-29 01:14:41 PDT
Comment on attachment 277677 [details] Patch for landing Clearing flags on attachment: 277677 Committed r200235: <http://trac.webkit.org/changeset/200235>
WebKit Commit Bot
Comment 6 2016-04-29 01:14:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.