Bug 156500
Summary: | Do not throw when getting selectionDirection/selectionStart/selectionEnd on input | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> |
Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Simon Pieters (:zcorpan)
See https://github.com/whatwg/html/pull/1006
var input = document.createElement('input');
input.type = 'checkbox';
input.selectionDirection; // should return null
input.selectionStart; // should return null
input.selectionEnd; // should return null
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Chris Dumez
I am not against this change but I am slightly worried about backward compatibility here. I think I'll wait a bit before implementing this.
Radar WebKit Bug Importer
<rdar://problem/25680941>
Chris Dumez
Chrome 52 and Firefox 47 still throw in this case.
Ahmad Saleem
I am not sure whether I am testing correctly here but when I copy the following snippet from Comment 0 into JSfiddle, I get following behavior across browsers:
Link - https://jsfiddle.net/sun1vzxq/show
*** Safari 15.6 on macOS 12.5 ***
Error in console - "<a class='gotoLine' href='#43:6'>43:6</a> TypeError: Type error"
*** Firefox Nightly 105 ***
No error in console
*** Chrome Canary 106 ***
No error in console
______
Just wanted to share updated results. Thanks!
Simon Pieters (:zcorpan)
It seems this is fixed in Safari TP 148 (Safari 16.0, WebKit 17614.1.17.1)
http://software.hixie.ch/utilities/js/live-dom-viewer/saved/10540
log: object "null" (0 props)
log: object "null" (0 props)
log: object "null" (0 props)
Ahmad Saleem
Indeed, it is fixed in Safari Technical Preview 150. Thanks for bump simon@bocoup.com.. I am going to mark this as "RESOLVED CONFIGURATION CHANGED".