Bug 155226

Summary: Rename Node.treeRoot to rootNode and turn it on by default
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, kling, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Renamed the function tonikitoo: review+

Ryosuke Niwa
Reported 2016-03-09 01:49:19 PST
Rename Node.treeRoot to rootNode and turn it on by default
Attachments
Renamed the function (70.32 KB, patch)
2016-03-09 01:58 PST, Ryosuke Niwa 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-03-09 01:58:22 PST
Created attachment 273415 [details] Renamed the function
Radar WebKit Bug Importer
Comment 2 2016-03-09 01:59:02 PST
<rdar://problem/25056663>
Antonio Gomes
Comment 3 2016-03-09 06:07:19 PST
Comment on attachment 273415 [details] Renamed the function View in context: https://bugs.webkit.org/attachment.cgi?id=273415&action=review r=me > Source/WebCore/html/FormAssociatedElement.cpp:86 > +// since inDocument flag maybe inaccurate. s/maybe/may be/ ?
Ryosuke Niwa
Comment 4 2016-03-09 14:10:34 PST
Thanks for the review! (In reply to comment #3) > Comment on attachment 273415 [details] > Renamed the function > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273415&action=review > > r=me > > > Source/WebCore/html/FormAssociatedElement.cpp:86 > > +// since inDocument flag maybe inaccurate. > > s/maybe/may be/ ? Revised the whole comment as: // Compute the highest ancestor instead of calling Node::rootNode in removedFrom / formRemovedFromTree // since inDocument flag on some form associated elements may not have been updated yet.
Ryosuke Niwa
Comment 5 2016-03-09 14:29:20 PST
Committed r197887: <http://trac.webkit.org/changeset/197887>
Note You need to log in before you can comment on or make changes to this bug.