Bug 154748

Summary: storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, ap, beidson, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 154968    
Attachments:
Description Flags
Patch v1 achristensen: review+

Ryan Haddad
Reported 2016-02-26 13:47:35 PST
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2 Most recent failure: <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r197193%20(12346)/results.html> Flakiness dashboard: <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fdeletedatabase-delayed-by-open-and-versionchange.html> --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-actual.txt @@ -22,7 +22,7 @@ versionChangeComplete = true onOpenSuccess(): -PASS blockedCalled is true +FAIL blockedCalled should be true. Threw exception ReferenceError: Can't find variable: blockedCalled h = event.target.result h.close()
Attachments
Patch v1 (3.89 KB, patch)
2016-03-21 15:39 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-02-26 14:16:12 PST
(In reply to comment #0) > onOpenSuccess(): > -PASS blockedCalled is true > +FAIL blockedCalled should be true. Threw exception ReferenceError: Can't > find variable: blockedCalled > h = event.target.result > h.close() That is... just nuts.
Ryan Haddad
Comment 2 2016-02-29 17:16:55 PST
Marked this test as flaky in <http://trac.webkit.org/projects/webkit/changeset/197377>
Brady Eidson
Comment 3 2016-03-03 10:24:08 PST
Ahhh. Okay, understood. This is just a timing problem in the test. In WK2, due to IPC variability, it *is* actually possible for the open + versionChange request to complete before the deleteRequest is even serviced, so it never gets blocked. We could change the test to extend the versionChange transaction until *after* blockedCalled is true, which will make it predictable.
Brady Eidson
Comment 4 2016-03-21 15:39:01 PDT
Created attachment 274628 [details] Patch v1
Brady Eidson
Comment 5 2016-03-21 15:57:58 PDT
http://trac.webkit.org/changeset/198504
Note You need to log in before you can comment on or make changes to this bug.