Bug 154637

Summary: Use more references in FocusNavigationScope
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151379    
Attachments:
Description Flags
Cleanup
none
Did one more rename cdumez: review+

Ryosuke Niwa
Reported 2016-02-24 00:38:22 PST
Per Darin's review comment in the bug 154630, use more references in FocusNavigationScope.
Attachments
Cleanup (12.88 KB, patch)
2016-02-24 14:40 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Did one more rename (12.81 KB, patch)
2016-02-24 14:45 PST, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-02-24 14:40:57 PST
Created attachment 272147 [details] Cleanup
WebKit Commit Bot
Comment 2 2016-02-24 14:43:25 PST
Attachment 272147 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2016-02-24 14:45:41 PST
Created attachment 272148 [details] Did one more rename
Chris Dumez
Comment 4 2016-02-24 15:17:34 PST
Comment on attachment 272148 [details] Did one more rename View in context: https://bugs.webkit.org/attachment.cgi?id=272148&action=review r=me > Source/WebCore/page/FocusController.cpp:170 > +FocusNavigationScope FocusNavigationScope::scopeOwnedByShadowHost(Node& node) This should even take an Element& in. Casting inside without check is terrible.
Ryosuke Niwa
Comment 5 2016-02-24 15:37:42 PST
Comment on attachment 272148 [details] Did one more rename View in context: https://bugs.webkit.org/attachment.cgi?id=272148&action=review >> Source/WebCore/page/FocusController.cpp:170 >> +FocusNavigationScope FocusNavigationScope::scopeOwnedByShadowHost(Node& node) > > This should even take an Element& in. Casting inside without check is terrible. Will fix. Thanks for the review!
Ryosuke Niwa
Comment 6 2016-02-24 15:37:44 PST
Committed r197055: <http://trac.webkit.org/changeset/197055>
Note You need to log in before you can comment on or make changes to this bug.