Bug 152177

Summary: Modern IDB: storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html fails
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-yosemite-wk2 none

Brady Eidson
Reported 2015-12-11 10:36:38 PST
Modern IDB: storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html fails Part of this is that the Request's transaction was set to null a bit too early. The other part is that the test expected the OpenDBRequest to have its result set to the database connection in case of error. The spec does *not* call for this, and the other browsers do not do it. So I'll fix the test, too.
Attachments
Patch v1 (9.85 KB, patch)
2015-12-11 10:40 PST, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.18 MB, application/zip)
2015-12-11 11:31 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-12-11 10:40:18 PST
Created attachment 267173 [details] Patch v1
Build Bot
Comment 2 2015-12-11 11:31:54 PST
Comment on attachment 267173 [details] Patch v1 Attachment 267173 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/546220 New failing tests: storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html
Build Bot
Comment 3 2015-12-11 11:31:57 PST
Created attachment 267176 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Brady Eidson
Comment 4 2015-12-11 11:57:09 PST
Added wk2 specific expectations. Fixed in https://trac.webkit.org/changeset/193970
Note You need to log in before you can comment on or make changes to this bug.