Bug 151732

Summary:

Modern IDB: storage/indexeddb/exceptions.html fails

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, buildbot, cdumez, commit-queue, esprehn+autocc, jsbell, kangil.han, kondapallykalyan, rniwa

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149117, 150882

Attachments:

Description	Flags
Patch v1	achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch for EWS and then maybe landing v1	none
Patch for eWS and then maybe landing v1	none

Brady Eidson

Reported 2015-12-01 17:08:21 PST

Modern IDB: storage/indexeddb/ fails

Attachments
Patch v1 (229.01 KB, patch) 2015-12-03 16:13 PST, Brady Eidson	achristensen: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (362.67 KB, application/zip) 2015-12-03 16:52 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (297.51 KB, application/zip) 2015-12-03 16:53 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (473.47 KB, application/zip) 2015-12-03 16:55 PST, Build Bot	no flags	Details
Patch for EWS and then maybe landing v1 (391.52 KB, patch) 2015-12-04 09:21 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch for eWS and then maybe landing v1 (391.53 KB, patch) 2015-12-04 09:29 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-12-03 10:20:13 PST

Modern IDB: storage/indexeddb/exceptions.html fails

Brady Eidson

Comment 2 2015-12-03 14:55:45 PST

Fixing this will require making many more IDLs be "RaisesExceptionWithMessage", and then adding lots of messages.

Brady Eidson

Comment 3 2015-12-03 15:51:35 PST

The test also caught a couple of very real violations of the spec.

Brady Eidson

Comment 4 2015-12-03 16:13:37 PST

Created attachment 266572 [details] Patch v1

Alex Christensen

Comment 5 2015-12-03 16:28:24 PST

Comment on attachment 266572 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266572&action=review Probably all the test expectations changes should be in platform/wk1 for now. r=me Hooray messages! > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:154 > + return 0; nullptr

Build Bot

Comment 6 2015-12-03 16:52:31 PST

Comment on attachment 266572 [details] Patch v1 Attachment 266572 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/513187 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2015-12-03 16:52:34 PST

Created attachment 266576 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2015-12-03 16:53:43 PST

Comment on attachment 266572 [details] Patch v1 Attachment 266572 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/513177 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2015-12-03 16:53:46 PST

Created attachment 266577 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2015-12-03 16:55:03 PST

Comment on attachment 266572 [details] Patch v1 Attachment 266572 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/513191 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2015-12-03 16:55:07 PST

Created attachment 266578 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Brady Eidson

Comment 12 2015-12-04 09:21:05 PST

Created attachment 266629 [details] Patch for EWS and then maybe landing v1

Brady Eidson

Comment 13 2015-12-04 09:29:07 PST

Created attachment 266630 [details] Patch for eWS and then maybe landing v1

Brady Eidson

Comment 14 2015-12-04 10:21:10 PST

Yay for successful EWS. CQ+'ing

WebKit Commit Bot

Comment 15 2015-12-04 11:07:36 PST

Comment on attachment 266630 [details] Patch for eWS and then maybe landing v1 Clearing flags on attachment: 266630 Committed r193428: <http://trac.webkit.org/changeset/193428>

WebKit Commit Bot

Comment 16 2015-12-04 11:07:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.