Bug 150616

Summary:

[EFL] Many layoutTests failed after r191623

Product:

WebKit

Reporter:

Hunseop Jeong <hs85.jeong>

Component:

WebKit EFL

Assignee:

Hunseop Jeong <hs85.jeong>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, clopez, gyuyoung.kim, hyatt, lucas.de.marchi, ossy, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149366

Attachments:

Description	Flags
WIP	none

Hunseop Jeong

Reported 2015-10-27 19:31:50 PDT

In r191623, Many layoutTests' expected results was changed. So we have to rebaseline the changed tests.

Attachments
WIP (9.62 MB, patch) 2015-10-28 02:06 PDT, Hunseop Jeong	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hunseop Jeong

Comment 1 2015-10-28 02:06:27 PDT

Created attachment 264202 [details] WIP

Hunseop Jeong

Comment 2 2015-10-28 02:08:04 PDT

I changed the expected results that was changed at r191623. I think we need more rebaseline work.

Csaba Osztrogonác

Comment 3 2015-10-28 02:46:12 PDT

(In reply to comment #2) > I changed the expected results that was changed at r191623. > I think we need more rebaseline work. I suggest you should land this huge patch in smaller pieces. Landing a huge patch can take ~ 10-20 minutes and probably it will fail due to conflict in LayoutTests/Changelog if somebody else landed a smaller patch touches the same changelog. cc-ing GTK guys too, you will need a similar patch.

Hunseop Jeong

Comment 4 2015-10-28 04:17:19 PDT

(In reply to comment #3) > (In reply to comment #2) > > I changed the expected results that was changed at r191623. > > I think we need more rebaseline work. > > I suggest you should land this huge patch in smaller pieces. > Landing a huge patch can take ~ 10-20 minutes and probably it will > fail due to conflict in LayoutTests/Changelog if somebody else landed > a smaller patch touches the same changelog. Okay, I will land it with smaller one.

Hunseop Jeong

Comment 5 2015-10-28 07:45:18 PDT

Rebaseline work - 1 Committed r191668: <http://trac.webkit.org/changeset/191668>

Hunseop Jeong

Comment 6 2015-10-28 10:08:55 PDT

Rebase line work - 2 Committed r191670: <http://trac.webkit.org/changeset/191670>

Hunseop Jeong

Comment 7 2015-10-28 11:20:14 PDT

Rebaseline work - last Committed r191681: <http://trac.webkit.org/changeset/191681>

Hunseop Jeong

Comment 8 2015-10-29 01:16:26 PDT

Rebaseline more tests Committed r191724: <http://trac.webkit.org/changeset/191724>

Hunseop Jeong

Comment 9 2015-10-29 02:20:12 PDT

I rebaseline the tests that was changed in r191623. So I close this bugs.

Note You need to log in before you can comment on or make changes to this bug.