Bug 149698

Summary:

Rewrite HTMLDetailsElement using HTMLSlotElement

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, cmarcelo, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, kling, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

149701, 150322

Bug Blocks:

148695, 150036, 150004

Attachments:

Description	Flags
WIP	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-mavericks	none
patch	kling: review+

Ryosuke Niwa

Reported 2015-09-30 23:28:48 PDT

Now that the basic infrastructure for shadow DOM is available, rewrite details element using the new API.

Attachments
WIP (71.84 KB, patch) 2015-09-30 23:30 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
patch (48.68 KB, patch) 2015-10-10 06:37 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (632.16 KB, application/zip) 2015-10-10 07:13 PDT, Build Bot	no flags	Details
patch (54.11 KB, patch) 2015-10-10 07:27 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2015-09-30 23:30:01 PDT

Created attachment 262237 [details] WIP

Ryosuke Niwa

Comment 2 2015-09-30 23:31:08 PDT

Maybe I should split the removal into a separate patch?

Antti Koivisto

Comment 3 2015-10-01 10:23:20 PDT

Seems fine like this too.

Ryosuke Niwa

Comment 4 2015-10-01 11:26:34 PDT

(In reply to comment #3) > Seems fine like this too. Okay. FWIW, I need to land my patch on https://bugs.webkit.org/show_bug.cgi?id=149701 first.

Antti Koivisto

Comment 5 2015-10-10 06:37:35 PDT

Created attachment 262824 [details] patch

WebKit Commit Bot

Comment 6 2015-10-10 06:39:49 PDT

Attachment 262824 [details] did not pass style-queue: ERROR: Source/WebCore/dom/SlotAssignment.h:46: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 7 2015-10-10 07:12:56 PDT

Comment on attachment 262824 [details] patch Attachment 262824 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/264687 New failing tests: fast/html/details-open2.html

Build Bot

Comment 8 2015-10-10 07:13:01 PDT

Created attachment 262825 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Antti Koivisto

Comment 9 2015-10-10 07:27:07 PDT

Created attachment 262826 [details] patch

WebKit Commit Bot

Comment 10 2015-10-10 07:29:53 PDT

Attachment 262826 [details] did not pass style-queue: ERROR: Source/WebCore/dom/SlotAssignment.h:46: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 11 2015-10-10 10:54:37 PDT

Comment on attachment 262826 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=262826&action=review r=me > Source/WebCore/html/HTMLDetailsElement.cpp:76 > + addShadowRoot(ShadowRoot::create(document, std::make_unique<SlotAssignment>(slotNameFunction))); As discussed on IRC, calling this virtual function from a constructor is a bit lame, even though this is a leaf class. I think we should just leave it in create() like you did with HTMLSummaryElement. > Source/WebCore/html/HTMLDetailsElement.h:49 > bool m_isOpen; > + HTMLSlotElement* m_summarySlot; > + HTMLSummaryElement* m_defaultSummary; Would be nice to initialize all of these explicitly here.

Antti Koivisto

Comment 12 2015-10-10 11:17:43 PDT

https://trac.webkit.org/r190840

Brent Fulgham

Comment 13 2015-10-12 10:59:54 PDT

This change introduced several Windows test failures because the baselines changed in the same way as the Mac port. I committed a rebaseline under <https://trac.webkit.org/r190861>.

Brent Fulgham

Comment 14 2015-10-12 11:06:41 PDT

There are a number of new test failures on EFL/GTK and Windows after this change was committed. See Bug 150036 for details. New failing tests are: fast/html/details-add-details-child-2.html fast/html/details-add-summary-child-1.html fast/html/details-add-summary-child-2.html

Radar WebKit Bug Importer

Comment 15 2015-10-27 20:10:35 PDT

<rdar://problem/23289343>

Note You need to log in before you can comment on or make changes to this bug.