Bug 149445

Summary: Add some style recalc tests for shadow DOM
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Adds tests koivisto: review+

Ryosuke Niwa
Reported 2015-09-21 20:34:09 PDT
Add tests to make sure we trigger necessary style recalc.
Attachments
Adds tests (13.06 KB, patch)
2015-09-21 20:36 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-09-21 20:36:47 PDT
Created attachment 261718 [details] Adds tests
Antti Koivisto
Comment 2 2015-09-21 20:58:04 PDT
Comment on attachment 261718 [details] Adds tests View in context: https://bugs.webkit.org/attachment.cgi?id=261718&action=review > LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42 > + else > + document.querySelector('p').getBoundingClientRect(); Not sure if this is reliable for forcing layout. We might optimize it away.
Ryosuke Niwa
Comment 3 2015-09-21 21:01:14 PDT
(In reply to comment #2) > Comment on attachment 261718 [details] > Adds tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261718&action=review > > > LayoutTests/fast/shadow-dom/shadow-layout-after-host-child-changes.html:42 > > + else > > + document.querySelector('p').getBoundingClientRect(); > > Not sure if this is reliable for forcing layout. We might optimize it away. Yeah, there isn't really a good way to force it within a browser.
Ryosuke Niwa
Comment 4 2015-09-21 21:01:45 PDT
Committed r190101: <http://trac.webkit.org/changeset/190101>
Note You need to log in before you can comment on or make changes to this bug.