Bug 149128

Summary: Control characters (Unicode category Cc) should be rendered visibly
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, clopez, eoconnor, ews-watchlist, gsnedders, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215643
https://bugs.webkit.org/show_bug.cgi?id=271869
Bug Depends on: 215643    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
zalan: review+
Patch for committing ews-feeder: commit-queue-

Attachments
Patch (57.64 KB, patch)
2021-08-12 19:47 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (66.50 KB, patch)
2021-08-12 21:11 PDT, Myles C. Maxfield 		zalan: review+
DetailsFormatted DiffDiff
Patch for committing (107.11 KB, patch)
2021-08-21 22:45 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-09-14 18:28:26 PDT
See also https://bugs.webkit.org/show_bug.cgi?id=149142
Sam Sneddon [:gsnedders]
Comment 2 2021-06-11 17:42:15 PDT
Through the /css/css-text/white-space/control-chars-* tests, this accounts for about 60 towards the browser-specific-failures for Safari on https://wpt.fyi (i.e., 1.5% of current failures).
Radar WebKit Bug Importer
Comment 3 2021-06-11 17:42:35 PDT
<rdar://problem/79224941>
Myles C. Maxfield
Comment 4 2021-08-12 13:46:50 PDT
Considering fixing this in https://bugs.webkit.org/show_bug.cgi?id=215643
Myles C. Maxfield
Comment 5 2021-08-12 19:47:58 PDT
Created attachment 435468 [details] Patch
Myles C. Maxfield
Comment 6 2021-08-12 21:11:13 PDT
Created attachment 435470 [details] Patch
Myles C. Maxfield
Comment 7 2021-08-12 21:13:28 PDT
Comment on attachment 435470 [details] Patch Marking as r?. EWS will show some red, but that's just because this patch depends on https://bugs.webkit.org/show_bug.cgi?id=215643 which hasn't been landed yet.
Myles C. Maxfield
Comment 8 2021-08-21 22:45:34 PDT
Created attachment 436110 [details] Patch for committing
EWS Watchlist
Comment 9 2021-08-21 22:46:39 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Myles C. Maxfield
Comment 10 2021-08-22 01:14:09 PDT
I need to investigate the iOS test failures.
Myles C. Maxfield
Comment 11 2021-08-22 14:05:01 PDT
Committed r281419 (240809@main): <https://commits.webkit.org/240809@main>
Myles C. Maxfield
Comment 12 2021-09-03 14:04:16 PDT
Committed r282021 (241326@main): <https://commits.webkit.org/241326@main>
Note You need to log in before you can comment on or make changes to this bug.