Bug 148314

Summary: Web Inspector: Unit should have checkmark, not Unchanged in visual sidebar
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: bburg, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: EasyFix, InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Video none

Timothy Hatcher
Reported 2015-08-21 10:44:18 PDT
See the video in this tweet. https://twitter.com/webkit/status/634766855375323137 The unit popup menu has Unchanged checked, when it should have px checked.
Attachments
Video (1.66 MB, video/quicktime)
2015-08-21 20:36 PDT, Timothy Hatcher 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-21 10:44:33 PDT
<rdar://problem/22381266>
Timothy Hatcher
Comment 2 2015-08-21 20:27:53 PDT
I am not seeing this in TOT now. Seems like it is fixed.
Timothy Hatcher
Comment 3 2015-08-21 20:34:44 PDT
Actually this reproduces if you ever pick Unchanged.
Timothy Hatcher
Comment 4 2015-08-21 20:36:12 PDT
Created attachment 259705 [details] Video It seems if you pick Unchanged once, the menu will keep it checked, even if the unchanged values has a unit in the menu that should be selected. Sounds like we need to reset selectedIndex before showing the menu or at sometime.
Devin Rousso
Comment 5 2015-09-11 22:40:41 PDT
Are you still seeing this issue? If so, could you please provide some specific steps to reproduce? I can't seem to get this to happen for me...
Blaze Burg
Comment 6 2015-11-20 12:59:33 PST
I cannot reproduce this either. Closing for now.
Note You need to log in before you can comment on or make changes to this bug.