Bug 145299

Summary: [Streams API] Implement ReadableStreamReader.releaseLock
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138967    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2015-05-21 23:40:33 PDT
Implement https://streams.spec.whatwg.org/#reader-release-lock
Attachments
Patch (13.40 KB, patch)
2015-06-16 10:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.37 KB, patch)
2015-06-18 00:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.38 KB, patch)
2015-06-18 01:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-06-16 10:08:37 PDT
Created attachment 254954 [details] Patch
Darin Adler
Comment 2 2015-06-17 15:48:43 PDT
Comment on attachment 254954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254954&action=review > Source/WebCore/Modules/streams/ReadableStream.h:70 > + bool hasReadPendingRequests() { return m_readRequests.size(); } Often we use !isEmpty instead of size for such things. In theory isEmpty might be faster than !size. > Source/WebCore/Modules/streams/ReadableStreamReader.h:36 > +#include "ExceptionCode.h" If we need only the type for ExceptionCode, then we typically declare it with: typedef int ExceptionCode; rather than including the header.
youenn fablet
Comment 3 2015-06-18 00:58:14 PDT
Created attachment 255096 [details] Patch for landing
youenn fablet
Comment 4 2015-06-18 01:01:15 PDT
Created attachment 255097 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-06-18 01:59:00 PDT
Comment on attachment 255097 [details] Patch for landing Clearing flags on attachment: 255097 Committed r185697: <http://trac.webkit.org/changeset/185697>
WebKit Commit Bot
Comment 6 2015-06-18 01:59:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.