Bug 145031

Summary:

REGRESSION(r184362) Crashes in region tests; caused by layout during parsing.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ap, buildbot, eric.carlson, fred.wang, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

276855

Attachments:

Description	Flags
Patch	rniwa: review+
Patch for landing.	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none

Jer Noble

Reported 2015-05-14 17:52:49 PDT

REGRESSION(r184362) Crashes in region tests; caused by layout during parsing.

Attachments
Patch (8.64 KB, patch) 2015-05-14 17:55 PDT, Jer Noble	rniwa: review+	Details Formatted Diff Diff
Patch for landing. (8.92 KB, patch) 2015-05-14 18:02 PDT, Jer Noble	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (710.04 KB, application/zip) 2015-05-14 18:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (750.04 KB, application/zip) 2015-05-14 18:39 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2015-05-14 17:55:24 PDT

Created attachment 253161 [details] Patch

Jer Noble

Comment 2 2015-05-14 18:02:41 PDT

Created attachment 253162 [details] Patch for landing.

Jer Noble

Comment 3 2015-05-14 18:09:58 PDT

Comment on attachment 253162 [details] Patch for landing. Waiting for the EWS bots; meantime, cq?.

Build Bot

Comment 4 2015-05-14 18:28:00 PDT

Comment on attachment 253162 [details] Patch for landing. Attachment 253162 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4851003820081152 New failing tests: fullscreen/video-controls-drag.html media/video-fullscreeen-only-controls.html media/media-captions-no-controls.html

Build Bot

Comment 5 2015-05-14 18:28:02 PDT

Created attachment 253164 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 6 2015-05-14 18:39:21 PDT

Comment on attachment 253162 [details] Patch for landing. Attachment 253162 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6099503568388096 New failing tests: fullscreen/video-controls-drag.html media/video-fullscreeen-only-controls.html media/media-captions-no-controls.html

Build Bot

Comment 7 2015-05-14 18:39:23 PDT

Created attachment 253165 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Alexey Proskuryakov

Comment 8 2015-05-14 20:11:56 PDT

Looks like the tests are failing. Jer, should we roll out r184359 and r184362? Bots are all red, and EWS is not doing well at all.

Alexey Proskuryakov

Comment 9 2015-05-14 20:14:00 PDT

I guess r184361 too.

Ryosuke Niwa

Comment 10 2015-05-14 20:27:37 PDT

(In reply to comment #8) > Looks like the tests are failing. Jer, should we roll out r184359 and > r184362? Bots are all red, and EWS is not doing well at all. Rollout is happening on webkit.org/b/145035.

Frédéric Wang Nélar

Comment 11 2026-10-12 02:49:04 PDT

The code has changed a lot in https://commits.webkit.org/253225@main so I'm tentatively closing this bug. Feel free to reopen if you think this is still valid.

Note You need to log in before you can comment on or make changes to this bug.