Bug 144981

Summary: Use Ref instead of PassRefPtr in WebCore/bindings
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Gyuyoung Kim
Reported 2015-05-13 18:36:37 PDT
SSIA
Attachments
Patch (19.96 KB, patch)
2015-05-13 18:47 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.17 KB, patch)
2015-05-18 19:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.22 KB, patch)
2015-05-18 21:40 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-05-13 18:47:26 PDT
Created attachment 253080 [details] Patch
Darin Adler
Comment 2 2015-05-17 10:53:29 PDT
Comment on attachment 253080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253080&action=review > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2655 > MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, > SerializationErrorMode throwExceptions) Not lined up any more. Better to put it all on one line, > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2670 > return 0; nullptr? > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2679 > return 0; nullptr? > Source/WebCore/bindings/objc/ObjCEventListener.h:41 > + static RefPtr<ObjCEventListener> wrap(ObjCListener); Should return Ref, not RefPtr. If you look at the implementation you’ll see it never returns null. > Source/WebCore/bindings/objc/ObjCEventListener.mm:55 > return wrapper; Need to use releaseNonNull here to convert the RefPtr into a Ref.
Gyuyoung Kim
Comment 3 2015-05-18 19:29:15 PDT
Created attachment 253359 [details] Patch for landing
Gyuyoung Kim
Comment 4 2015-05-18 19:29:51 PDT
(In reply to comment #2) > Comment on attachment 253080 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253080&action=review > > > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2655 > > MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, > > SerializationErrorMode throwExceptions) > > Not lined up any more. Better to put it all on one line, > > > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2670 > > return 0; > > nullptr? > > > Source/WebCore/bindings/js/SerializedScriptValue.cpp:2679 > > return 0; > > nullptr? > > > Source/WebCore/bindings/objc/ObjCEventListener.h:41 > > + static RefPtr<ObjCEventListener> wrap(ObjCListener); > > Should return Ref, not RefPtr. If you look at the implementation you’ll see > it never returns null. > > > Source/WebCore/bindings/objc/ObjCEventListener.mm:55 > > return wrapper; > > Need to use releaseNonNull here to convert the RefPtr into a Ref. All done ! Thanks.
WebKit Commit Bot
Comment 5 2015-05-18 20:20:53 PDT
Comment on attachment 253359 [details] Patch for landing Rejecting attachment 253359 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 253359, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6377800806170624
Gyuyoung Kim
Comment 6 2015-05-18 21:40:41 PDT
Created attachment 253364 [details] Patch for landing
WebKit Commit Bot
Comment 7 2015-05-18 22:55:30 PDT
Comment on attachment 253364 [details] Patch for landing Clearing flags on attachment: 253364 Committed r184543: <http://trac.webkit.org/changeset/184543>
WebKit Commit Bot
Comment 8 2015-05-18 22:55:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.