Created attachment 276508[details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 276501[details]
Patch v1
View in context: https://bugs.webkit.org/attachment.cgi?id=276501&action=review
Code changes look good. Look into the failing test before landing, after the other patch is landed.
> LayoutTests/imported/blink/storage/indexeddb/blob-basics-metadata.html:106
> + cursor.continue();
> +// evalAndLog("cursor.continue();");
this doesn't look good. I guess it exists like this in blink, though...
The Yosemite bot failure is super mysterious.
In my reading of the code, there's exactly one place it could come from, and that one place shouldn't ever really happen:
RefPtr<IDBRequest> IDBObjectStore::putOrAdd(JSC::ExecState& state, JSC::JSValue value, RefPtr<IDBKey> key, IndexedDB::ObjectStoreOverwriteMode overwriteMode, InlineKeyCheck inlineKeyCheck, ExceptionCodeWithMessage& ec)
{
LOG(IndexedDB, "IDBObjectStore::putOrAdd");
auto context = scriptExecutionContextFromExecState(&state);
if (!context) {
ec.code = IDBDatabaseException::UnknownError;
return nullptr;
}
...
(In reply to comment #4)
> Comment on attachment 276501[details]
> Patch v1
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276501&action=review
>
> Code changes look good. Look into the failing test before landing, after
> the other patch is landed.
Yup, looking into it now.
>
> > LayoutTests/imported/blink/storage/indexeddb/blob-basics-metadata.html:106
> > + cursor.continue();
> > +// evalAndLog("cursor.continue();");
>
> this doesn't look good. I guess it exists like this in blink, though...
By calling it natively, the exception is uncaught and aborts the test.
Calling with evalAndLog, the exception is caught, and then the test times out.
Prefer to leave the original in place for future diffing against the blink test.
Might have gone without saying, but to be explicit: Can't reproduce that failure locally.
To validate my theory on what the bot is seeing, uploading a new patch for EWS.
Created attachment 276513[details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
AHA.
stderr to the rescue
ERROR: Failed copying File contents to a Blob temporary file for storage in IndexedDB (/Volumes/Data/EWS/WebKit/LayoutTests/imported/blink/storage/indexeddb/resources/empty.txt to /var/folders/7n/s62c21h54p549lcpn5v012mc0000gn/T/DumpRenderTree-rzL3dC/BlobHd0Wr3)
/Volumes/Data/EWS/WebKit/Source/WebCore/platform/network/BlobRegistryImpl.cpp(320) : auto WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles(const Vector<WTF::String> &, std::function<void (const Vector<String> &)>)::(anonymous class)::operator()() const
Created attachment 276516[details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 276517[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Hmmm, I'm developing a working theory here - This is an empty file, literally 0 bytes.
I wonder if the behavior of our filesystem calls are subtley different on Yosemite vs other OSXs with regards to their responses on 0 byte files.
Hopefully the logging in the patch I just uploaded will tell us this, and if so, it should be an easy fix.
Created attachment 276520[details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 276523[details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 276529[details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
On a whim, I just tried stashing my changes and then applying the patch locally, using svn-apply.
The empty.txt file - which is in the patch - is not created on the filesystem.
So attempts to reference it do, of course, fail.
This isn't a bug with the patch, but rather a bug with svn-apply.
This patch will be fine as-is when I actually push the changed, but just cannot be svn-applied.
*sigh*
Filed https://bugs.webkit.org/show_bug.cgi?id=156649 for the svn-apply issue.
Created attachment 276534[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
2016-04-15 13:24 PDT, Brady Eidson
buildbot: commit-queue-
2016-04-15 14:08 PDT, Build Bot
2016-04-15 14:27 PDT, Brady Eidson
2016-04-15 14:30 PDT, Build Bot
2016-04-15 15:11 PDT, Build Bot
2016-04-15 15:33 PDT, Build Bot
2016-04-15 15:44 PDT, Brady Eidson
2016-04-15 16:28 PDT, Build Bot
2016-04-15 16:41 PDT, Build Bot
2016-04-15 16:47 PDT, Brady Eidson
2016-04-15 17:12 PDT, Build Bot
2016-04-15 18:00 PDT, Build Bot