Bug 142304

Summary: Only Heap should be in charge of deciding how to select a subspace for a type
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 141174    
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2015-03-04 12:57:17 PST
Currently the DFG, FTL, and JSCellInlines have some code duplication to decide which subspace/allocator to use for which type. While working on bug 141174, I realized that I'll need to repeat this pattern again, and so I decided to reduce the code duplication somewhat.
Attachments
the patch (10.37 KB, patch)
2015-03-04 12:59 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-03-04 12:59:38 PST
Created attachment 247885 [details] the patch
Mark Lam
Comment 2 2015-03-04 13:01:57 PST
Comment on attachment 247885 [details] the patch r=me
Filip Pizlo
Comment 3 2015-03-04 13:33:14 PST
Landed in http://trac.webkit.org/changeset/181019
Note You need to log in before you can comment on or make changes to this bug.