Bug 141472

Summary: bmalloc buildfix on 32 bit Linux (x86/ARM)
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: cgarcia, clopez, commit-queue, ggaren, gyuyoung.kim, ossy
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140162    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-02-11 05:54:57 PST
bmalloc buildfix on 32 bit Linux (x86/ARM)
Attachments
Patch (2.52 KB, patch)
2015-02-11 05:56 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2015-02-11 06:13 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-11 05:56:14 PST
Created attachment 246386 [details] Patch
Csaba Osztrogonác
Comment 2 2015-02-11 05:58:17 PST
Comment on attachment 246386 [details] Patch It works on 32 bit, but breaks the 64 bit :-/
Csaba Osztrogonác
Comment 3 2015-02-11 06:04:11 PST
Comment on attachment 246386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246386&action=review > Source/bmalloc/bmalloc/FixedVector.h:62 > - void clear() { shrink(0ul); } > + void clear() { shrink(0u); } The original 0ul fails on 32bit: ../../Source/bmalloc/bmalloc/FixedVector.h: In instantiation of 'void bmalloc::FixedVector<T, Capacity>::clear() [with T = void*; unsigned int Capacity = 256u]': ../../Source/bmalloc/bmalloc/Deallocator.cpp:91:23: required from here ../../Source/bmalloc/bmalloc/FixedVector.h:62:30: error: call of overloaded 'shrink(long unsigned int)' is ambiguous ../../Source/bmalloc/bmalloc/FixedVector.h:62:30: note: candidates are: ../../Source/bmalloc/bmalloc/FixedVector.h:112:13: note: void bmalloc::FixedVector<T, Capacity>::shrink(T*) [with T = void*; unsigned int Capacity = 256u] ../../Source/bmalloc/bmalloc/FixedVector.h:105:13: note: void bmalloc::FixedVector<T, Capacity>::shrink(size_t) [with T = void*; unsigned int Capacity = 256u; size_t = unsigned int] The modified 0u fails on 64 bit: ./../Source/bmalloc/bmalloc/FixedVector.h: In instantiation of 'void bmalloc::FixedVector<T, Capacity>::clear() [with T = void*; long unsigned int Capacity = 256ul]': ../../Source/bmalloc/bmalloc/Deallocator.cpp:91:23: required from here ../../Source/bmalloc/bmalloc/FixedVector.h:62:29: error: call of overloaded 'shrink(unsigned int)' is ambiguous ../../Source/bmalloc/bmalloc/FixedVector.h:62:29: note: candidates are: ../../Source/bmalloc/bmalloc/FixedVector.h:112:13: note: void bmalloc::FixedVector<T, Capacity>::shrink(T*) [with T = void*; long unsigned int Capacity = 256ul] ../../Source/bmalloc/bmalloc/FixedVector.h:105:13: note: void bmalloc::FixedVector<T, Capacity>::shrink(size_t) [with T = void*; long unsigned int Capacity = 256ul; size_t = long unsigned int]
Csaba Osztrogonác
Comment 4 2015-02-11 06:13:10 PST
Created attachment 246387 [details] Patch try to make 32 and 64 bit happy in the same time
Gyuyoung Kim
Comment 5 2015-02-11 07:26:46 PST
Comment on attachment 246387 [details] Patch rs=me. I think this patch isn't change behavior.
Gyuyoung Kim
Comment 6 2015-02-11 07:34:45 PST
(In reply to comment #5) > Comment on attachment 246387 [details] > Patch > > rs=me. I think this patch isn't change behavior. typo: s/isn't/doesn't/g
WebKit Commit Bot
Comment 7 2015-02-11 08:12:15 PST
Comment on attachment 246387 [details] Patch Clearing flags on attachment: 246387 Committed r179927: <http://trac.webkit.org/changeset/179927>
WebKit Commit Bot
Comment 8 2015-02-11 08:12:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.