Bug 133960
| Summary: | WebVideoFullscreenInterfaceAVKit could use a session object to implicitly clean up between fullscreen sessions. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> |
| Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | fred.wang |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | iPhone / iPad | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Jeremy Jones
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:792
> > + [m_window setHidden:YES];
> > + [m_window setRootViewController:nil];
> > + [m_playerViewController setDelegate:nil];
> > + [m_playerViewController setPlayerController:nil];
> > + m_playerViewController = nil;
> > + m_viewController = nil;
> > + m_window = nil;
> > + [m_videoLayer removeFromSuperlayer];
> > + m_videoLayer = nil;
> > + [m_videoLayerContainer removeFromSuperlayer];
> > + [m_videoLayerContainer setPlayerViewController:nil];
> > + m_videoLayerContainer = nil;
>
> So much stuff.
Maybe use a session object
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
It's now called VideoPresentationInterfaceAVKitLegacy.mm so probably not worth spending time on this anymore.
I see a few cleanup at https://searchfox.org/wubkat/rev/266307597d7056165626f44f5814cfe277fdd869/Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm#877 but not that much.