Bug 132480

Summary:

[New Multicolumn] Remove the old multicolumn code

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kangil.han, kondapallykalyan, pdr, rniwa, schenney, sergio, simon.fraser, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Patch	kling: review+

Dave Hyatt

Reported 2014-05-02 12:32:43 PDT

Remove the old code and refactor everything to shift more code into RenderBlockFlow.

Attachments
Patch (162.97 KB, patch) 2014-05-02 12:34 PDT, Dave Hyatt	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (451.50 KB, application/zip) 2014-05-02 13:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (470.25 KB, application/zip) 2014-05-02 14:16 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (496.75 KB, application/zip) 2014-05-02 14:29 PDT, Build Bot	no flags	Details
Patch (162.78 KB, patch) 2014-05-05 15:32 PDT, Dave Hyatt	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (762.43 KB, application/zip) 2014-05-05 17:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (759.69 KB, application/zip) 2014-05-05 18:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (766.47 KB, application/zip) 2014-05-05 19:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (622.53 KB, application/zip) 2014-05-05 19:30 PDT, Build Bot	no flags	Details
Patch (278.08 KB, patch) 2014-05-06 12:59 PDT, Dave Hyatt	kling: review+	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2014-05-02 12:34:07 PDT

Created attachment 230684 [details] Patch Not for review. Just want to check EWS.

WebKit Commit Bot

Comment 2 2014-05-02 12:35:03 PDT

Attachment 230684 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayer.cpp:408: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderLayer.cpp:968: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/rendering/LayoutState.h:63: The parameter name "state" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/RenderBlock.h:440: Missing space inside { }. [whitespace/braces] [5] Total errors found: 4 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2014-05-02 13:39:22 PDT

Comment on attachment 230684 [details] Patch Attachment 230684 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5131180600983552 New failing tests: fast/multicol/overflow-across-columns-percent-height.html fast/repaint/line-flow-with-floats-8.html css3/unicode-bidi-isolate-basic.html fast/multicol/overflow-across-columns.html fast/repaint/line-flow-with-floats-5.html fast/block/float/028.html fast/multicol/positive-leading.html fast/multicol/client-rects-spanners-complex.html css2.1/t0905-c5525-fltwidth-00-c-g.html fast/lists/008-vertical.html fast/block/float/026.html fast/repaint/line-flow-with-floats-7.html fast/multicol/client-rects.html fast/lists/008.html fast/forms/file/file-input-direction.html fast/repaint/line-flow-with-floats-4.html css1/box_properties/float_on_text_elements.html fast/repaint/line-flow-with-floats-2.html fast/repaint/line-flow-with-floats-6.html fast/multicol/newmulticol/client-rects.html fast/multicol/overflow-unsplittable.html fast/multicol/column-count-with-rules.html fast/repaint/line-flow-with-floats-10.html fast/multicol/client-rects-spanners.html fast/repaint/line-flow-with-floats-1.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/repaint/line-flow-with-floats-3.html fast/repaint/line-flow-with-floats-9.html fast/regions/repaint/line-flow-with-floats-in-regions.html fast/css/absolute-child-with-percent-height-inside-relative-parent.html

Build Bot

Comment 4 2014-05-02 13:39:33 PDT

Created attachment 230692 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-05-02 14:16:34 PDT

Comment on attachment 230684 [details] Patch Attachment 230684 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4845044511014912 New failing tests: fast/multicol/overflow-across-columns-percent-height.html fast/repaint/line-flow-with-floats-8.html css3/unicode-bidi-isolate-basic.html fast/multicol/overflow-across-columns.html fast/repaint/line-flow-with-floats-5.html fast/block/float/028.html fast/multicol/positive-leading.html fast/multicol/client-rects-spanners-complex.html css2.1/t0905-c5525-fltwidth-00-c-g.html fast/lists/008-vertical.html fast/block/float/026.html fast/repaint/line-flow-with-floats-7.html fast/multicol/client-rects.html fast/lists/008.html fast/forms/file/file-input-direction.html fast/repaint/line-flow-with-floats-4.html css1/box_properties/float_on_text_elements.html fast/repaint/line-flow-with-floats-2.html fast/repaint/line-flow-with-floats-6.html fast/multicol/newmulticol/client-rects.html fast/multicol/overflow-unsplittable.html fast/multicol/column-count-with-rules.html fast/repaint/line-flow-with-floats-10.html fast/multicol/client-rects-spanners.html fast/repaint/line-flow-with-floats-1.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/repaint/line-flow-with-floats-3.html fast/repaint/line-flow-with-floats-9.html fast/regions/repaint/line-flow-with-floats-in-regions.html fast/css/absolute-child-with-percent-height-inside-relative-parent.html

Build Bot

Comment 6 2014-05-02 14:16:40 PDT

Created attachment 230698 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-05-02 14:29:35 PDT

Comment on attachment 230684 [details] Patch Attachment 230684 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5631981303889920 New failing tests: fast/multicol/overflow-across-columns-percent-height.html fast/repaint/line-flow-with-floats-8.html css3/unicode-bidi-isolate-basic.html fast/multicol/overflow-across-columns.html fast/repaint/line-flow-with-floats-5.html fast/block/float/028.html fast/multicol/positive-leading.html fast/multicol/client-rects-spanners-complex.html css2.1/t0905-c5525-fltwidth-00-c-g.html fast/lists/008-vertical.html fast/block/float/026.html fast/repaint/line-flow-with-floats-7.html fast/multicol/client-rects.html fast/lists/008.html fast/forms/file/file-input-direction.html fast/repaint/line-flow-with-floats-4.html css1/box_properties/float_on_text_elements.html fast/repaint/line-flow-with-floats-2.html fast/repaint/line-flow-with-floats-6.html fast/multicol/newmulticol/client-rects.html fast/multicol/overflow-unsplittable.html fast/multicol/column-count-with-rules.html fast/repaint/line-flow-with-floats-10.html fast/multicol/client-rects-spanners.html fast/repaint/line-flow-with-floats-1.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/repaint/line-flow-with-floats-3.html fast/repaint/line-flow-with-floats-9.html fast/regions/repaint/line-flow-with-floats-in-regions.html fast/css/absolute-child-with-percent-height-inside-relative-parent.html

Build Bot

Comment 8 2014-05-02 14:29:42 PDT

Created attachment 230699 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Dave Hyatt

Comment 9 2014-05-05 15:32:48 PDT

Created attachment 230861 [details] Patch

Build Bot

Comment 10 2014-05-05 17:52:00 PDT

Comment on attachment 230861 [details] Patch Attachment 230861 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5338383245115392 New failing tests: fast/multicol/newmulticol/client-rects.html fast/multicol/client-rects-spanners.html fast/multicol/client-rects.html fast/multicol/client-rects-spanners-complex.html

Build Bot

Comment 11 2014-05-05 17:52:06 PDT

Created attachment 230874 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 12 2014-05-05 18:18:10 PDT

Comment on attachment 230861 [details] Patch Attachment 230861 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4677547228921856 New failing tests: fast/multicol/newmulticol/client-rects.html fast/multicol/client-rects-spanners.html fast/multicol/client-rects.html fast/multicol/client-rects-spanners-complex.html

Build Bot

Comment 13 2014-05-05 18:18:16 PDT

Created attachment 230877 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 14 2014-05-05 19:02:03 PDT

Comment on attachment 230861 [details] Patch Attachment 230861 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6202815206653952 New failing tests: fast/multicol/newmulticol/client-rects.html fast/multicol/client-rects-spanners.html fast/multicol/client-rects.html fast/multicol/client-rects-spanners-complex.html

Build Bot

Comment 15 2014-05-05 19:02:10 PDT

Created attachment 230881 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 16 2014-05-05 19:29:57 PDT

Comment on attachment 230861 [details] Patch Attachment 230861 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5138534121865216 New failing tests: fast/multicol/newmulticol/client-rects.html fast/multicol/client-rects-spanners.html fast/multicol/client-rects.html fast/multicol/client-rects-spanners-complex.html

Build Bot

Comment 17 2014-05-05 19:30:04 PDT

Created attachment 230882 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Dave Hyatt

Comment 18 2014-05-06 12:59:40 PDT

Created attachment 230925 [details] Patch

Dave Hyatt

Comment 19 2014-05-06 14:36:24 PDT

Landed in r168380.

Note You need to log in before you can comment on or make changes to this bug.