Bug 129553

Summary: Refactor css3/filters/huge-region test
Product: WebKit Reporter: Adenilson Cavalcanti Silva <savagobr>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, krit, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68469    
Attachments:
Description Flags
Patch none

Adenilson Cavalcanti Silva
Reported 2014-03-01 13:28:36 PST
This test uses a blur filter in a huge element which previously wouldn't be filtered at all, it should really become 2 tests: a) one for invalid blur values (it uses 2147483648px which will be clamped to 500). b) another for big regions, it would require to have the following dimensions: 4096x4096 (a bit less if you consider Margin + Border).
Attachments
Patch (3.27 KB, patch)
2014-03-07 12:38 PST, Adenilson Cavalcanti Silva 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adenilson Cavalcanti Silva
Comment 1 2014-03-07 12:38:22 PST
Created attachment 226149 [details] Patch
Dirk Schulze
Comment 2 2014-03-07 12:44:02 PST
Comment on attachment 226149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226149&action=review > LayoutTests/css3/filters/huge-region.html:7 > + width: 4096px; > + height: 4096px; This probably should delayed until we get filter scaling working properly again. But then with much bigger values.
Adenilson Cavalcanti Silva
Comment 3 2014-03-07 12:53:08 PST
Dirk Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. What would be a limit that would *also* block the execution once we have filter scaling working again?
Dirk Schulze
Comment 4 2014-03-07 12:57:04 PST
(In reply to comment #3) > Dirk > > Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. > > What would be a limit that would *also* block the execution once we have filter scaling working again? Anything bigger than 4096 seems fine :) I would like to keep this bug open until we fixed filter scaling and add the blur test to another bug report.
Adenilson Cavalcanti Silva
Comment 5 2014-03-07 13:04:27 PST
Ins't that covered in this bug: https://bugs.webkit.org/show_bug.cgi?id=129555
WebKit Commit Bot
Comment 6 2014-03-21 12:10:27 PDT
Comment on attachment 226149 [details] Patch Clearing flags on attachment: 226149 Committed r166089: <http://trac.webkit.org/changeset/166089>
WebKit Commit Bot
Comment 7 2014-03-21 12:10:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.