Bug 129144

Summary: Disallow the use of -webkit-user-modify on shadow pseudo elements
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, ap, commit-queue, darin, enrica, eoconnor, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 129034    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2014-02-21 01:47:29 PST
It's a terrible idea to let authors override the editability of UA shadow DOM via -webkit-user-modify. In fact, we already have a bunch of -webkit-user-modify: read-only !important rules in html.css. In order to resolve the bug 129034, completely disallow them in all cases in the engine itself. Heck, we probably want to disallow -webkit-user-modify anywhere in the shadow DOM since it's a legacy CSS property that's hurting the performance for us.
Attachments
Patch (10.69 KB, patch)
2014-02-21 01:52 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-21 01:52:09 PST
Created attachment 224843 [details] Patch
Geoffrey Garen
Comment 2 2014-02-21 13:55:50 PST
Comment on attachment 224843 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-02-21 14:27:54 PST
Comment on attachment 224843 [details] Patch Clearing flags on attachment: 224843 Committed r164501: <http://trac.webkit.org/changeset/164501>
WebKit Commit Bot
Comment 4 2014-02-21 14:27:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.