Bug 128815

Summary: [CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
abucur: review-
Patch
abucur: review+
Patch for landing none

Radu Stavila
Reported 2014-02-14 07:05:39 PST
Currently, the contents of the box is correctly clipped by the region at the border box. However, the box decorations are clipped at the content box.
Attachments
Patch (23.73 KB, patch)
2014-02-17 07:45 PST, Radu Stavila 		abucur: review-
DetailsFormatted DiffDiff
Patch (24.95 KB, patch)
2014-02-17 08:43 PST, Radu Stavila 		abucur: review+
DetailsFormatted DiffDiff
Patch for landing (24.96 KB, patch)
2014-02-17 08:55 PST, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radu Stavila
Comment 1 2014-02-17 07:45:16 PST
Created attachment 224368 [details] Patch
Andrei Bucur
Comment 2 2014-02-17 08:25:57 PST
Comment on attachment 224368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224368&action=review > Source/WebCore/rendering/RenderRegion.cpp:525 > mappedRect.intersect(flowThreadPortionRect()); I think the correct order of operations is to expand the flowThreadPortionRect() with the paddings and then intersect. This way: 1. You expand only when actually clipping 2. You don't expand a rectangle already intersected with the flowThreadPortionRect() that doesn't need the extra space to display correctly. > Source/WebCore/rendering/RenderRegion.cpp:533 > + if (isFirstRegion()) { This should be startRegion. > Source/WebCore/rendering/RenderRegion.cpp:543 > + if (isLastRegion()) { This should be lastRegion.
Radu Stavila
Comment 3 2014-02-17 08:43:40 PST
Created attachment 224377 [details] Patch
Andrei Bucur
Comment 4 2014-02-17 08:47:16 PST
Comment on attachment 224377 [details] Patch r=me. Before committing, please update the CL with the new helper you implemented. Thanks!
Radu Stavila
Comment 5 2014-02-17 08:55:42 PST
Created attachment 224381 [details] Patch for landing
WebKit Commit Bot
Comment 6 2014-02-17 11:05:30 PST
Comment on attachment 224381 [details] Patch for landing Clearing flags on attachment: 224381 Committed r164231: <http://trac.webkit.org/changeset/164231>
Note You need to log in before you can comment on or make changes to this bug.