Bug 127089

Summary: [GTK] Add CSS Grid Layout as experimental feature
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: WebKitGTKAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2014-01-16 02:10:04 PST
We have a mechanism to enable experimental settings via a environment variable called WEBKITGTK_EXPERIMENTAL_FEATURES. It seems like CSS Grid Layout could be something to be enabled this way at this moment. JFYI, there's not compilation flag for it.
Attachments
Patch (3.07 KB, patch)
2014-01-16 02:18 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-01-16 02:18:01 PST
Created attachment 221349 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-16 02:18:52 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2014-01-16 07:52:07 PST
Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off?
Sergio Villar Senin
Comment 4 2014-01-16 08:27:53 PST
(In reply to comment #3) > Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off? The thing I guess is that it's always built as it isn't behind any preprocessor guard. Knowing that it's a spec in WD status, that it's still prefixed in WebKit, and provided we have this ExperimentalFeatures thingy, I think it's a good idea to add it there.
Manuel Rego Casasnovas
Comment 5 2014-01-16 09:21:34 PST
(In reply to comment #3) > Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off? Like Sergio says the preprocessor guard was removed a while ago in r117613 (May 2012). So grid layout support is always compiled. There're tests turning on this feature but any of them turning it off.
WebKit Commit Bot
Comment 6 2014-01-17 12:51:50 PST
Comment on attachment 221349 [details] Patch Clearing flags on attachment: 221349 Committed r162215: <http://trac.webkit.org/changeset/162215>
WebKit Commit Bot
Comment 7 2014-01-17 12:51:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.