Bug 126449

Summary: [WebGL2] Implement compressedTex{Sub}Image*, copyTexSubImage3D
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404, 209510    
Attachments:
Description Flags
Patch none

Dean Jackson
Reported 2014-01-03 12:13:04 PST
Implement the new texStorage methods void texStorage2D(GLenum target, GLsizei levels, GLenum internalformat, GLsizei width, GLsizei height); void texStorage3D(GLenum target, GLsizei levels, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth); void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, ArrayBufferView? pixels); void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, ImageData? data); void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, HTMLImageElement image); void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, HTMLCanvasElement canvas); void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLenum type, HTMLVideoElement video); void copyTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height); (Maybe 3d should be split into a separate bug)
Attachments
Patch (554.13 KB, patch)
2020-07-14 14:47 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-01-03 12:13:25 PST
<rdar://problem/15002343>
Dean Jackson
Comment 2 2014-01-03 13:15:08 PST
Also: void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, ArrayBufferView data); void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, ArrayBufferView data);
Kenneth Russell
Comment 3 2020-07-13 16:57:09 PDT
Taking this as a follow-on to the other recent texture work.
Kenneth Russell
Comment 4 2020-07-14 10:13:38 PDT
Changing synopsis to reflect functions being implemented under this bug.
Kenneth Russell
Comment 5 2020-07-14 14:47:25 PDT
Created attachment 404287 [details] Patch
Dean Jackson
Comment 6 2020-07-14 15:00:11 PDT
Comment on attachment 404287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404287&action=review > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1311 > + synthesizeGLError( > + GraphicsContextGL::INVALID_OPERATION, "compressedTexImage2D", > + "a buffer is bound to PIXEL_UNPACK_BUFFER"); We typically wouldn't split this over lines, but it's ok.
EWS
Comment 7 2020-07-14 15:37:25 PDT
Committed r264377: <https://trac.webkit.org/changeset/264377> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404287 [details].
Radar WebKit Bug Importer
Comment 8 2020-07-14 15:38:14 PDT
<rdar://problem/65568996>
Kenneth Russell
Comment 9 2020-07-14 15:53:28 PDT
Comment on attachment 404287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404287&action=review >> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1311 >> + "a buffer is bound to PIXEL_UNPACK_BUFFER"); > > We typically wouldn't split this over lines, but it's ok. Understood - this was to make emacs' auto-indenting be compatible with WebKit's style. Otherwise it would auto-indent the second line to the open parenthesis, leading to a style error.
Note You need to log in before you can comment on or make changes to this bug.