Bug 122414

Summary: context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108370, 113742    
Attachments:
Description Flags
Patch rniwa: review+

Alexey Proskuryakov
Reported 2013-10-06 10:22:48 PDT
The following layout test is very flaky on Mac. editing/spelling/context-menu-suggestions-multiword-selection.html This started with <http://trac.webkit.org/changeset/156901>. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fspelling%2Fcontext-menu-suggestions-multiword-selection.html
Attachments
Patch (4.88 KB, patch)
2013-10-07 07:18 PDT, Grzegorz Czajkowski 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-06 10:28:15 PDT
Marked as flaky in r156990.
Grzegorz Czajkowski
Comment 2 2013-10-07 04:36:32 PDT
Committed r157034: <http://trac.webkit.org/changeset/157034>
Grzegorz Czajkowski
Comment 3 2013-10-07 04:49:24 PDT
Marked as flaky context-menu-suggestions-subword-selection.html too. It started failing for Mac similarly to context-menu-suggestions-multiword-selection.html.
Grzegorz Czajkowski
Comment 4 2013-10-07 07:18:52 PDT
Created attachment 213579 [details] Patch
Ryosuke Niwa
Comment 5 2013-10-07 11:02:43 PDT
Comment on attachment 213579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review > LayoutTests/editing/spelling/resources/util.js:28 > + }, true /* Doesn't produce logs on success. */ ); I think it's fine to output this. We just need to rebaseline the tests.
Grzegorz Czajkowski
Comment 6 2013-10-07 11:54:16 PDT
(In reply to comment #5) > (From update of attachment 213579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review > > > LayoutTests/editing/spelling/resources/util.js:28 > > + }, true /* Doesn't produce logs on success. */ ); > > I think it's fine to output this. We just need to rebaseline the tests. Sure, will do that before landing. We should be aware that more spellchecking tests include utils.js and those need to be rebaselined too.
Grzegorz Czajkowski
Comment 7 2013-10-08 02:56:53 PDT
Committed r157094: <http://trac.webkit.org/changeset/157094>
Note You need to log in before you can comment on or make changes to this bug.