Bug 122279

Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, d-r, esprehn+autocc, fmalita, kondapallykalyan, pdr, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122213    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2013-10-03 09:05:12 PDT
[WebIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
Attachments
Patch (82.21 KB, patch)
2013-10-03 09:11 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (15.02 KB, patch)
2013-10-04 00:00 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (17.75 KB, patch)
2013-10-04 03:26 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-10-03 09:11:58 PDT
Created attachment 213264 [details] Patch
Zan Dobersek
Comment 2 2013-10-03 14:27:13 PDT
Comment on attachment 213264 [details] Patch I'll recheck the changes to remove unnecessary annotations on interfaces with no operations.
Zan Dobersek
Comment 3 2013-10-04 00:00:39 PDT
Created attachment 213338 [details] Patch
Zan Dobersek
Comment 4 2013-10-04 03:26:58 PDT
Created attachment 213351 [details] Patch
Zan Dobersek
Comment 5 2013-10-04 03:27:36 PDT
Comment on attachment 213351 [details] Patch Had to add the attribute to one exception interface and three more interfaces that don't declare any operations but implement different interfaces that do declare operations.
Darin Adler
Comment 6 2013-10-05 07:31:27 PDT
Comment on attachment 213351 [details] Patch I am not sure I understand the comment about needing to add this to interfaces that don't declare any operations but implement different interfaces that do declare operations. But I’ll take your word from it that it’s helpful. Just remember that we have to remove all of these so any we don’t add now is one less thing to come back to later.
Zan Dobersek
Comment 7 2013-10-06 11:01:08 PDT
The 'A implements B' statement requires all the objects implementing the interface A to also implement the interface B. The bindings generator does not propagate the interface attributes on the interface B to the interface A, so the OperationsNotDeletable attribute was added to the few interfaces that don't declare any operations but implement other interfaces that do.
Zan Dobersek
Comment 8 2013-10-06 11:09:21 PDT
Comment on attachment 213351 [details] Patch Clearing flags on attachment: 213351 Committed r156997: <http://trac.webkit.org/changeset/156997>
Zan Dobersek
Comment 9 2013-10-06 11:09:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.