Bug 118353

Summary:

Get rid of multiple inheritance support from the bindings generators

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, buildbot, commit-queue, d-r, esprehn+autocc, fmalita, ggaren, gyuyoung.kim, haraken, jberlin, kangil.han, laszlo.gombos, pdr, rniwa, schenney, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.w3.org/TR/WebIDL/#idl-interfaces

Bug Depends on:

117785, 118014, 118029, 118142, 118170, 118178, 118305, 118349, 118351, 161897

Bug Blocks:

Attachments:

Description	Flags
Patch	haraken: review+, buildbot: commit-queue-
Test for mac ews	buildbot: commit-queue-
Another test for mac-ews	buildbot: commit-queue-
Another test for mac-ews	buildbot: commit-queue-
Another test for mac-ews	buildbot: commit-queue-
Another test for mac-ews	buildbot: commit-queue-
Another test for mac-ews	buildbot: commit-queue-
Another test for mac-ews	none
Patch	haraken: review+
Patch for landing	none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none

Chris Dumez

Reported 2013-07-03 04:35:32 PDT

Remove multiple inheritance support from the bindings generator as this is no longer supported in Web IDL and it makes the generator more complex than it needs to be. Multiple inheritance support should no longer be needed once our SVG interfaces have all been updated to use Web IDL 'implements' statements instead (as per the latest SVG2 specification).

Attachments
Patch (18.00 KB, patch) 2013-07-11 05:11 PDT, Chris Dumez	haraken: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Test for mac ews (18.81 KB, patch) 2013-07-11 07:33 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (19.41 KB, patch) 2013-07-12 00:24 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (19.12 KB, patch) 2013-07-12 06:05 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (19.04 KB, patch) 2013-07-12 06:55 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (19.73 KB, patch) 2013-07-15 23:55 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (17.92 KB, patch) 2013-07-16 04:06 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Another test for mac-ews (16.59 KB, patch) 2013-07-16 05:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (17.30 KB, patch) 2013-07-16 05:54 PDT, Chris Dumez	haraken: review+	Details Formatted Diff Diff
Patch for landing (16.70 KB, patch) 2013-07-16 06:48 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (642.10 KB, application/zip) 2013-07-16 07:57 PDT, WebKit Commit Bot	no flags	Details
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-07-11 05:11:14 PDT

Created attachment 206448 [details] Patch

Kentaro Hara

Comment 2 2013-07-11 05:16:09 PDT

Comment on attachment 206448 [details] Patch This looks great. Thanks for doing this.

Build Bot

Comment 3 2013-07-11 05:35:06 PDT

Comment on attachment 206448 [details] Patch Attachment 206448 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1051216

Build Bot

Comment 4 2013-07-11 05:37:21 PDT

Comment on attachment 206448 [details] Patch Attachment 206448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/936603

Chris Dumez

Comment 5 2013-07-11 05:41:27 PDT

Hmm, mac port uses multiple inheritance at least in one place: ] interface Node #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C : Object, EventTarget #endif /* defined(LANGUAGE_OBJECTIVE_C) */ { I need to investigate how to solve this.

Chris Dumez

Comment 6 2013-07-11 07:33:05 PDT

Created attachment 206461 [details] Test for mac ews

Build Bot

Comment 7 2013-07-11 08:07:27 PDT

Comment on attachment 206461 [details] Test for mac ews Attachment 206461 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1059085

Build Bot

Comment 8 2013-07-11 08:15:38 PDT

Comment on attachment 206461 [details] Test for mac ews Attachment 206461 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/954899

Chris Dumez

Comment 9 2013-07-12 00:24:29 PDT

Created attachment 206510 [details] Another test for mac-ews

Build Bot

Comment 10 2013-07-12 00:48:51 PDT

Comment on attachment 206510 [details] Another test for mac-ews Attachment 206510 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/973967

Build Bot

Comment 11 2013-07-12 00:49:55 PDT

Comment on attachment 206510 [details] Another test for mac-ews Attachment 206510 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/973968

Chris Dumez

Comment 12 2013-07-12 06:05:41 PDT

Created attachment 206531 [details] Another test for mac-ews

Build Bot

Comment 13 2013-07-12 06:18:56 PDT

Comment on attachment 206531 [details] Another test for mac-ews Attachment 206531 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1045283

Build Bot

Comment 14 2013-07-12 06:45:50 PDT

Comment on attachment 206531 [details] Another test for mac-ews Attachment 206531 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1063104

Chris Dumez

Comment 15 2013-07-12 06:55:37 PDT

Created attachment 206540 [details] Another test for mac-ews

Build Bot

Comment 16 2013-07-12 07:19:33 PDT

Comment on attachment 206540 [details] Another test for mac-ews Attachment 206540 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1064101

Build Bot

Comment 17 2013-07-12 07:28:56 PDT

Comment on attachment 206540 [details] Another test for mac-ews Attachment 206540 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1054317

Chris Dumez

Comment 18 2013-07-15 23:55:31 PDT

Created attachment 206730 [details] Another test for mac-ews

Build Bot

Comment 19 2013-07-16 00:11:01 PDT

Comment on attachment 206730 [details] Another test for mac-ews Attachment 206730 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1084114

Build Bot

Comment 20 2013-07-16 00:20:17 PDT

Comment on attachment 206730 [details] Another test for mac-ews Attachment 206730 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1086088

Chris Dumez

Comment 21 2013-07-16 04:06:26 PDT

Created attachment 206754 [details] Another test for mac-ews

Build Bot

Comment 22 2013-07-16 04:24:24 PDT

Comment on attachment 206754 [details] Another test for mac-ews Attachment 206754 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1089169

Build Bot

Comment 23 2013-07-16 04:44:30 PDT

Comment on attachment 206754 [details] Another test for mac-ews Attachment 206754 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1085179

Chris Dumez

Comment 24 2013-07-16 05:01:36 PDT

Created attachment 206766 [details] Another test for mac-ews

Chris Dumez

Comment 25 2013-07-16 05:54:36 PDT

Created attachment 206769 [details] Patch

Chris Dumez

Comment 26 2013-07-16 05:56:55 PDT

@haraken: Could you please take another look? I had to take a more conservative approach and keep supporting multiple inheritance in the IDL parser. Unfortunately, the ObjC bindings generator still relies on multiple inheritance for the Node interface and I don't understand those bindings enough to fix the issue :/

Kentaro Hara

Comment 27 2013-07-16 06:06:44 PDT

Comment on attachment 206769 [details] Patch OK, lgtm. Landing easy parts first makes sense.

Chris Dumez

Comment 28 2013-07-16 06:48:30 PDT

Created attachment 206777 [details] Patch for landing

WebKit Commit Bot

Comment 29 2013-07-16 07:57:24 PDT

Comment on attachment 206777 [details] Patch for landing Rejecting attachment 206777 [details] from commit-queue. New failing tests: compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/1086187

WebKit Commit Bot

Comment 30 2013-07-16 07:57:33 PDT

Created attachment 206780 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Chris Dumez

Comment 31 2013-07-16 08:02:43 PDT

Comment on attachment 206777 [details] Patch for landing Failure is unrelated, cq+ again.

WebKit Commit Bot

Comment 32 2013-07-16 09:23:39 PDT

Comment on attachment 206777 [details] Patch for landing Clearing flags on attachment: 206777 Committed r152725: <http://trac.webkit.org/changeset/152725>

WebKit Commit Bot

Comment 33 2013-07-16 09:23:47 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.