Bug 118002

Summary: [CSS Shapes] Clear overflowing line's segments in pushShapeContentOverflowBelowTheContentBox
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
proposed patch
none
updated patch after r152800 none

Zoltan Horvath
Reported 2013-06-25 15:39:49 PDT
When the last line in the shape overlaps with the shape bottom boundaries we need to clear the computed segments. (We need to compute the segments anyway, since shape-outside's code uses the same code path to determine its segments and the line containing is not a requirement in that case.) Rather then doing the job in RenderBlock::LineBreaker::nextLineBreak I moved the functionality to its correct place to pushShapeContentOverflowBelowTheContentBox. Now all the overflow related functionality is located in one function.
Attachments
proposed patch (7.06 KB, patch)
2013-06-25 15:47 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
updated patch after r152800 (7.07 KB, patch)
2013-07-17 14:54 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-06-25 15:47:44 PDT
Created attachment 205425 [details] proposed patch
Zoltan Horvath
Comment 2 2013-07-17 14:54:35 PDT
Created attachment 206917 [details] updated patch after r152800
Dave Hyatt
Comment 3 2013-07-19 10:21:56 PDT
Comment on attachment 206917 [details] updated patch after r152800 r=me
WebKit Commit Bot
Comment 4 2013-07-19 10:44:52 PDT
Comment on attachment 206917 [details] updated patch after r152800 Clearing flags on attachment: 206917 Committed r152906: <http://trac.webkit.org/changeset/152906>
WebKit Commit Bot
Comment 5 2013-07-19 10:44:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.