Bug 117566

Summary: [CSS Regions] -webkit-background-clip: text; does not clip the background in regions
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, buildbot, commit-queue, esprehn+autocc, glenn, rniwa, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 none

Max Vujovic
Reported 2013-06-12 15:53:50 PDT
Patch with test case coming up!
Attachments
Patch (8.23 KB, patch)
2013-06-12 16:20 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1.40 MB, application/zip)
2013-06-13 02:01 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Max Vujovic
Comment 1 2013-06-12 16:20:36 PDT
Created attachment 204544 [details] Patch
Alexandru Chiculita
Comment 2 2013-06-12 16:27:23 PDT
Comment on attachment 204544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review r=me > Source/WebCore/rendering/RenderFlowThread.cpp:306 > + PaintBehavior paintBehavior = 0; nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator.
Build Bot
Comment 3 2013-06-13 02:01:04 PDT
Comment on attachment 204544 [details] Patch Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/847086 New failing tests: http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Build Bot
Comment 4 2013-06-13 02:01:06 PDT
Created attachment 204562 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Max Vujovic
Comment 5 2013-06-13 09:34:22 PDT
(In reply to comment #3) > (From update of attachment 204544 [details]) > Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/847086 > > New failing tests: > http/tests/security/cross-origin-plugin-private-browsing-toggled.html This failure looks unrelated and doesn't repro locally.
Max Vujovic
Comment 6 2013-06-13 09:35:25 PDT
Comment on attachment 204544 [details] Patch Setting cq+.
Max Vujovic
Comment 7 2013-06-13 09:36:22 PDT
(In reply to comment #2) > (From update of attachment 204544 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review > > r=me > > > Source/WebCore/rendering/RenderFlowThread.cpp:306 > > + PaintBehavior paintBehavior = 0; > > nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator. Yup, I'm working on the selection phase patch right now :)
WebKit Commit Bot
Comment 8 2013-06-13 09:50:53 PDT
Comment on attachment 204544 [details] Patch Clearing flags on attachment: 204544 Committed r151555: <http://trac.webkit.org/changeset/151555>
WebKit Commit Bot
Comment 9 2013-06-13 09:50:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.