Bug 117259

Summary: [CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mibalan, mvujovic, rniwa, stavila, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 7555, 111585    
Bug Blocks: 116295    
Attachments:
Description Flags
HTML showing the problem
none
Patch
none
Simpler approach
koivisto: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
Patch fixing failing newmulticol test none

Radu Stavila
Reported 2013-06-05 09:40:26 PDT
Created attachment 203862 [details] HTML showing the problem If an element is flowed into a region and it overflows the region, upon changing the region's flow-from to "none" in the :hover style would fail to repaint the portion of the element that was outside of the region. See attached test case.
Attachments
HTML showing the problem (802 bytes, text/html)
2013-06-05 09:40 PDT, Radu Stavila 		no flags
Details
Patch (6.97 KB, patch)
2013-12-19 04:33 PST, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Simpler approach (10.17 KB, patch)
2013-12-19 06:06 PST, Radu Stavila 		koivisto: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (785.17 KB, application/zip)
2013-12-19 09:09 PST, Build Bot 		no flags
Details
Patch fixing failing newmulticol test (10.17 KB, patch)
2013-12-20 02:24 PST, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Michelangelo De Simone
Comment 1 2013-06-13 10:12:53 PDT
Still repros on today's nightly (r151543)
Max Vujovic
Comment 2 2013-06-13 13:55:24 PDT
Changing this bug to block the CSS Regions master bug, not the other way around.
Radu Stavila
Comment 3 2013-12-19 04:33:59 PST
Created attachment 219639 [details] Patch
Antti Koivisto
Comment 4 2013-12-19 05:29:03 PST
Comment on attachment 219639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219639&action=review > Source/WebCore/rendering/RenderRegion.cpp:746 > + rect.moveBy(baseRect.location()); > + rect.unite(baseRect); This pair doesn't look correct. How are rect and baseRect in the same coordinate system in unite()?
Antti Koivisto
Comment 5 2013-12-19 05:36:56 PST
baseRect is obtained with RenderBlockFlow::clippedOverflowRectForRepaint which at least in theory can have a location that differs from the box location.
Radu Stavila
Comment 6 2013-12-19 06:06:56 PST
Created attachment 219643 [details] Simpler approach
Build Bot
Comment 7 2013-12-19 09:08:58 PST
Comment on attachment 219643 [details] Simpler approach Attachment 219643 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48758024 New failing tests: fast/multicol/newmulticol/column-rules-fixed-height.html
Build Bot
Comment 8 2013-12-19 09:09:05 PST
Created attachment 219654 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Radu Stavila
Comment 9 2013-12-20 02:24:47 PST
Created attachment 219744 [details] Patch fixing failing newmulticol test
WebKit Commit Bot
Comment 10 2013-12-20 05:41:26 PST
Comment on attachment 219744 [details] Patch fixing failing newmulticol test Clearing flags on attachment: 219744 Committed r160905: <http://trac.webkit.org/changeset/160905>
WebKit Commit Bot
Comment 11 2013-12-20 05:41:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.