Bug 113247

Summary: [v8] Binding integrity: add ScriptWrappable::init() and call it.
Product: WebKit Reporter: Thomas Sepez <tsepez>
Component: WebCore Misc.Assignee: Thomas Sepez <tsepez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, andersca, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112191    
Attachments:
Description Flags
Patch.
none
Patch, correct method name.
none
Patch, add missing newline. abarth: review-

Thomas Sepez
Reported 2013-03-25 16:04:33 PDT
First part of multiple part patch to address bug 112191. Adds stubs to ScriptWrappable.h and calls them in the appropriate places.
Attachments
Patch. (194.92 KB, patch)
2013-03-25 16:51 PDT, Thomas Sepez 		no flags
DetailsFormatted DiffDiff
Patch, correct method name. (194.92 KB, patch)
2013-03-25 17:07 PDT, Thomas Sepez 		no flags
DetailsFormatted DiffDiff
Patch, add missing newline. (194.83 KB, patch)
2013-03-25 17:13 PDT, Thomas Sepez 		abarth: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thomas Sepez
Comment 1 2013-03-25 16:51:12 PDT
Created attachment 194948 [details] Patch.
Thomas Sepez
Comment 2 2013-03-25 17:07:09 PDT
Created attachment 194954 [details] Patch, correct method name.
Thomas Sepez
Comment 3 2013-03-25 17:13:09 PDT
Created attachment 194955 [details] Patch, add missing newline.
Adam Barth
Comment 4 2013-03-30 11:30:56 PDT
Comment on attachment 194955 [details] Patch, add missing newline. View in context: https://bugs.webkit.org/attachment.cgi?id=194955&action=review This patch does too much. We should just add the call to init in the first patch. > Source/WebCore/bindings/v8/ScriptWrappable.h:138 > + template <typename T>static void init(T* object) { } In debug, we should set a bool on this object to ensure that init is always called.
Anders Carlsson
Comment 5 2013-05-02 11:49:08 PDT
V8 is gone from WebKit.
Note You need to log in before you can comment on or make changes to this bug.