Bug 113165

Summary: Custom Elements Refactoring: The name V8CustomElement is confusing.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, esprehn+autocc, haraken, japhet, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99688    
Attachments:
Description Flags
Patch none

Hajime Morrita
Reported 2013-03-24 18:49:36 PDT
From bug 112191. There is no CustomElement class in C++ side. So having this name breaks the convention that expects the C++ class without "V8" prefix. It should have another name and should be got rid of.
Attachments
Patch (16.25 KB, patch)
2013-03-25 22:26 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2013-03-25 22:26:57 PDT
Created attachment 195006 [details] Patch
Kent Tamura
Comment 2 2013-03-25 22:30:36 PDT
Comment on attachment 195006 [details] Patch rubber stamped
Hajime Morrita
Comment 3 2013-03-25 23:38:25 PDT
Committed r146851: <http://trac.webkit.org/changeset/146851>
Note You need to log in before you can comment on or make changes to this bug.