Bug 113088

Summary: [CSS Shaders] Clamp css_MixColor before the blending and compositing steps
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, dino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71392    
Attachments:
Description Flags
Patch for Bots none

Max Vujovic
Reported 2013-03-22 11:53:00 PDT
The blending and compositing operations from the spec [1] expect that they are operating on valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to this range to avoid implementation-dependent behavior for invalid color input. [1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
Attachments
Patch for Bots (9.93 KB, patch)
2013-03-22 11:59 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Max Vujovic
Comment 1 2013-03-22 11:59:35 PDT
Created attachment 194610 [details] Patch for Bots Running the bots.
Max Vujovic
Comment 2 2013-03-22 16:27:19 PDT
Comment on attachment 194610 [details] Patch for Bots Thanks Dean!
WebKit Review Bot
Comment 3 2013-03-22 16:58:30 PDT
Comment on attachment 194610 [details] Patch for Bots Clearing flags on attachment: 194610 Committed r146683: <http://trac.webkit.org/changeset/146683>
WebKit Review Bot
Comment 4 2013-03-22 16:58:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.