Bug 111693

Summary: Custom Elements: should support non-HTML namespaces.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Web Components Team <webcomponents-bugzilla>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ericbidelman, esprehn+autocc, haraken, japhet, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99688    
Attachments:
Description Flags
Patch
none
Patch none

Hajime Morrita
Reported 2013-03-07 00:23:36 PST
Currently it only supports SVG. It should also support non-HTML namespaces like SVG.
Attachments
Patch (18.34 KB, patch)
2013-03-26 22:24 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (18.62 KB, patch)
2013-03-27 19:00 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2013-03-26 22:24:57 PDT
Created attachment 195224 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2013-03-27 09:28:48 PDT
Comment on attachment 195224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195224&action=review > Source/WebCore/bindings/v8/CustomElementHelpers.h:59 > + static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0); Can we not pass by ref here? The ptr thing looks a bit weird.
Hajime Morrita
Comment 3 2013-03-27 19:00:15 PDT
Created attachment 195456 [details] Patch
Hajime Morrita
Comment 4 2013-03-27 19:05:01 PDT
(In reply to comment #2) > > Source/WebCore/bindings/v8/CustomElementHelpers.h:59 > > + static bool isValidPrototypeParameter(const ScriptValue&, ScriptState*, AtomicString* namespaceURI = 0); > > Can we not pass by ref here? The ptr thing looks a bit weird. Right, fixed.
WebKit Review Bot
Comment 5 2013-03-28 07:32:36 PDT
Comment on attachment 195456 [details] Patch Clearing flags on attachment: 195456 Committed r147113: <http://trac.webkit.org/changeset/147113>
WebKit Review Bot
Comment 6 2013-03-28 07:32:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.