Bug 110776

Summary: More style cleanup in GIFImageReader
Product: WebKit Reporter: Hin-Chung Lam <hclam>
Component: ImagesAssignee: Hin-Chung Lam <hclam>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98098    
Attachments:
Description Flags
Patch allan.jensen: review+, webkit.review.bot: commit-queue-

Hin-Chung Lam
Reported 2013-02-25 11:36:46 PST
This include some variables renaming.
Attachments
Patch (13.18 KB, patch)
2013-02-25 11:40 PST, Hin-Chung Lam 		allan.jensen: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hin-Chung Lam
Comment 1 2013-02-25 11:40:01 PST
Created attachment 190099 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-02-25 12:22:52 PST
Comment on attachment 190099 [details] Patch LGTM
WebKit Review Bot
Comment 3 2013-02-25 17:35:47 PST
Comment on attachment 190099 [details] Patch Rejecting attachment 190099 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 190099, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: d at 657 (offset 35 lines). Hunk #15 succeeded at 666 (offset 35 lines). Hunk #16 succeeded at 695 (offset 35 lines). Hunk #17 succeeded at 762 (offset 36 lines). Hunk #18 FAILED at 752. Hunk #19 FAILED at 793. 5 out of 19 hunks FAILED -- saving rejects to file Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Allan Sandfeld Jensen']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16748622
Hin-Chung Lam
Comment 4 2013-02-27 19:11:53 PST
Committed r144257: <http://trac.webkit.org/changeset/144257>
Note You need to log in before you can comment on or make changes to this bug.