Bug 109455

Created attachment 187601 [details] Patch

What happens if you set an override path on an already open icon-database?

(In reply to comment #2) > What happens if you set an override path on an already open icon-database? It won't have any effect unless it's closed and re-opened. The same as when calling setLocalStorageDirectory, setCookieStorageDirectory, etc. after the web process was started.

Brady, could you please have a look at the patch? I think that this needs to go through you.

Comment on attachment 187601 [details] Patch I'm confused as to why this is important. It's increasing the API surface to accomplish something that is already possible today - opening the icondatabase at the platform default path.

(In reply to comment #5) If I'm not missing anything, it's only possible to open it from outside the current C API with: - WebIconDatabase::setDatabasePath(const String& path) - From WebContext::setIconDatabasePath(const String& path) - Finally from WKContextSetIconDatabasePath(WKContextRef contextRef, WKStringRef iconDatabasePath) This code path doesn't use the value returned by WebContext::platformDefaultIconDatabasePath() the same way it is possible with platformDefaultDatabaseDirectory(), platformDefaultLocalStorageDirectory() and platformDefaultCookieStorageDirectory(). Another way would be to set all of them through the C API client and not use the platformDefault* methods at all, if you think it would be cleaner.

(In reply to comment #6) > (In reply to comment #5) > > If I'm not missing anything, it's only possible to open it from outside the current C API with: > - WebIconDatabase::setDatabasePath(const String& path) > - From WebContext::setIconDatabasePath(const String& path) > - Finally from WKContextSetIconDatabasePath(WKContextRef contextRef, WKStringRef iconDatabasePath) > > This code path doesn't use the value returned by WebContext::platformDefaultIconDatabasePath() the same way it is possible with platformDefaultDatabaseDirectory(), platformDefaultLocalStorageDirectory() and platformDefaultCookieStorageDirectory(). > > Another way would be to set all of them through the C API client and not use the platformDefault* methods at all, if you think it would be cleaner. WKContextSetIconDatabasePath is the call in the current C API that opens the icon database. You can call it with the default path to open the database at the default path. The notion of a "default path" was a mistake. Clients should always have to explicitly provide a path.

Comment on attachment 187601 [details] Patch (In reply to comment #7) > WKContextSetIconDatabasePath is the call in the current C API that opens the icon database. > > You can call it with the default path to open the database at the default path. > > The notion of a "default path" was a mistake. Clients should always have to explicitly provide a path. Alright, that makes sense. I've gone that way with the patch for bug 111435, thanks for the input.