Bug 108671

Summary: Import IETC DOM tests
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Tools / TestsAssignee: Zan Dobersek <zan>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, eoconnor, eric.carlson, feature-media-reviews, gyuyoung.kim, mjs, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76198    
Attachments:
Description Flags
Patch
none
Patch buildbot: commit-queue-

Zan Dobersek
Reported 2013-02-01 11:48:30 PST
Import IETC DOM tests
Attachments
Patch (537.13 KB, patch)
2013-02-01 12:00 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (537.39 KB, patch)
2013-02-02 00:43 PST, Zan Dobersek 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-01 12:00:35 PST
Created attachment 186096 [details] Patch
Zan Dobersek
Comment 2 2013-02-01 12:39:01 PST
Comment on attachment 186096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186096&action=review Two nits I'd like to discuss with potential reviewers: > LayoutTests/ChangeLog:21 > + * ietestcenter/dom/core/DOMImplementation_createDocument-expected.txt: Added. How should the paths be stylized? Would 'ietestcenter/DOM/Core/*' work better that 'ietestcenter/dom/core/*' and similar? > LayoutTests/ietestcenter/dom/core/DOMImplementation_createDocument.htm:3 > + Internet Explorer Test Pages Copyright © 2012 Microsoft Corporation. All rights reserved. The license boilerplates use 2012. While the tests are possibly even older that that, shold 2013 be used? (The license used in all the test cases was copied from a random flexbox test.)
WebKit Review Bot
Comment 3 2013-02-01 20:07:15 PST
Comment on attachment 186096 [details] Patch Attachment 186096 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16338464 New failing tests: ietestcenter/dom/inheritance/Prototype_SVGSVGElement.htm ietestcenter/dom/inheritance/Prototype_SVGCircleElement.htm ietestcenter/dom/inheritance/Prototype_SVGRectElement.htm
Zan Dobersek
Comment 4 2013-02-02 00:26:51 PST
(In reply to comment #3) > (From update of attachment 186096 [details]) > Attachment 186096 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/16338464 > > New failing tests: > ietestcenter/dom/inheritance/Prototype_SVGSVGElement.htm > ietestcenter/dom/inheritance/Prototype_SVGCircleElement.htm > ietestcenter/dom/inheritance/Prototype_SVGRectElement.htm These tests seem to pass with Chromium 26.0.1386.0 and fail with Chromium 26.0.1397.2.
Zan Dobersek
Comment 5 2013-02-02 00:43:31 PST
Created attachment 186219 [details] Patch
Build Bot
Comment 6 2013-02-02 01:48:17 PST
Comment on attachment 186219 [details] Patch Attachment 186219 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16337676
Zan Dobersek
Comment 7 2013-03-25 05:43:15 PDT
I'm not interested anymore in importing IETC tests as in too many cases they test IE-only behavior or even things that are not actually covered by the related spec. Not to mention the closed nature of the test suites they are providing, making it extremely hard to scrap all the test cases or to simply provide feedback.
Note You need to log in before you can comment on or make changes to this bug.