Bug 103593

Summary: [Shadow] Internals should have a method to cause distribution.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, morrita, philn, webcomponents-bugzilla, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102646    
Attachments:
Description Flags
Patch
none
WIP buildbot: commit-queue-

Shinya Kawanaka
Reported 2012-11-28 20:32:53 PST
We would like to have a method to ensure distribution for measuring Shadow DOM performance. Though content.getDistributeNodes() can cause distribution, however it creates a vector of distributed elements. We woud like to measure just distribution performance, we have to have it.
Attachments
Patch (3.45 KB, patch)
2012-11-28 21:16 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (5.03 KB, patch)
2012-11-28 22:05 PST, Shinya Kawanaka 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-28 21:16:21 PST
Created attachment 176639 [details] Patch
Build Bot
Comment 2 2012-11-28 21:22:57 PST
Comment on attachment 176639 [details] Patch Attachment 176639 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15031507
Shinya Kawanaka
Comment 3 2012-11-28 22:05:29 PST
Created attachment 176648 [details] WIP
Hajime Morrita
Comment 4 2012-11-28 23:11:49 PST
Comment on attachment 176639 [details] Patch Is there any other way to make this happen without internals? Measuring performance through internals API sounds a bit too artificial.
Shinya Kawanaka
Comment 5 2012-11-29 00:48:19 PST
(In reply to comment #4) > (From update of attachment 176639 [details]) > Is there any other way to make this happen without internals? > Measuring performance through internals API sounds a bit too artificial. We have: - offsetLeft - getDistributedNodes() But this causes layout (getDistributedNodes() causes layout now). I have no idea we have another way.
Dimitri Glazkov (Google)
Comment 6 2012-11-29 10:10:56 PST
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 176639 [details] [details]) > > Is there any other way to make this happen without internals? > > Measuring performance through internals API sounds a bit too artificial. > > We have: > - offsetLeft > - getDistributedNodes() > But this causes layout (getDistributedNodes() causes layout now). > > I have no idea we have another way. As long as this produces meaningful measurement, I am okay with using internals in perf tests.
Build Bot
Comment 7 2012-11-29 11:42:19 PST
Comment on attachment 176648 [details] WIP Attachment 176648 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15027929
Hajime Morrita
Comment 8 2012-11-29 16:25:55 PST
(In reply to comment #6) > > > > I have no idea we have another way. > > As long as this produces meaningful measurement, I am okay with using internals in perf tests. Talked to Shinya offline and found that we can omit layout time by setting display:none to the host. If even null-layout prevents meaningful measurement, the speed of content distribution must not matter. Unfortunately as expected, it matters at least for now ;-)
Shinya Kawanaka
Comment 9 2012-12-06 01:38:50 PST
(In reply to comment #8) > (In reply to comment #6) > > > > > > I have no idea we have another way. > > > > As long as this produces meaningful measurement, I am okay with using internals in perf tests. > > Talked to Shinya offline and found that we can omit layout time > by setting display:none to the host. > If even null-layout prevents meaningful measurement, > the speed of content distribution must not matter. > Unfortunately as expected, it matters at least for now ;-) Let close this for now. When the time when we really need this comes, let's reopen this.
Note You need to log in before you can comment on or make changes to this bug.