Bug 102517

Summary: [WTR] WebKitTestRunner should be able to run tests using fixed layout
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: Tools / TestsAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, hausmann, jturcotte, kenneth, rakuco, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95959, 102811    
Attachments:
Description Flags
Patch none

Thiago Marcos P. Santos
Reported 2012-11-16 08:07:36 PST
CSS Device Adaption tests expects the browser to use fixed layout. AFAIK all the ports don't enable this mode on WTR and we cannot enable this mode by default because it will break most of the baselines.
Attachments
Patch (11.38 KB, patch)
2012-11-19 23:58 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-11-19 23:58:06 PST
Created attachment 175161 [details] Patch
Thiago Marcos P. Santos
Comment 2 2012-11-20 06:59:43 PST
Adding more reviewers. At the bug 102811, I'm adding the same functionality for the Qt port, but it depends on the WK2 generic bits added by this patch.
Kenneth Rohde Christiansen
Comment 3 2012-11-20 08:01:24 PST
Comment on attachment 175161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136 > +{ > + WKRetainPtr<WKStringRef> useFixedLayoutKey(AdoptWK, WKStringCreateWithUTF8CString("UseFixedLayout")); > + > + return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false); couldn't there not be other options that we don't support? How should we handle them? Shouldn't we check if there are other entries in the dictionary? and if so, return false?
Thiago Marcos P. Santos
Comment 4 2012-11-20 08:10:42 PST
Comment on attachment 175161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175161&action=review >> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:136 >> + return m_usingFixedLayout == (options ? WKBooleanGetValue(static_cast<WKBooleanRef>(WKDictionaryGetItemForKey(options, useFixedLayoutKey.get()))) : false); > > couldn't there not be other options that we don't support? How should we handle them? > > Shouldn't we check if there are other entries in the dictionary? and if so, return false? Right now this is the only option supported. Prior to this patch, this code was an inline returning true for all platforms other than Mac.
Thiago Marcos P. Santos
Comment 5 2012-11-20 08:53:50 PST
Comment on attachment 175161 [details] Patch Clearing flag until I get a reply from Kenneth on the review.
WebKit Review Bot
Comment 6 2012-11-20 09:15:04 PST
Comment on attachment 175161 [details] Patch Clearing flags on attachment: 175161 Committed r135287: <http://trac.webkit.org/changeset/135287>
WebKit Review Bot
Comment 7 2012-11-20 09:15:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.