Bug 101316
| Summary: | ShadowRoot::insertedInto is called many times without calling removedFrom when parsing <video controls> | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> |
| Component: | DOM | Assignee: | Web Components Team <webcomponents-bugzilla> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | dglazkov, dominicc, eric.carlson, morrita, rniwa, webcomponents-bugzilla |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 72352 | ||
Shinya Kawanaka
I noticed this when I was working for Bug 100922. This might cause mysterious errors in future.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Shinya Kawanaka
The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto().
This seems a bad signal...
Hajime Morrita
(In reply to comment #1)
> The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto().
> This seems a bad signal...
It sounds reasonable to get rid of the shadow construction from insertedInto().
I'm not sure where is the best place though.
It needs further investigation.
Dimitri Glazkov (Google)
Yeah, this is crufty. insertedInto is a really low-level hook, and it's tempting to use it various convenient purposes. However, being a low-level hook, it's also a minefield in situations like this.
Ryosuke Niwa
configureMediaControls() is now called in HTMLMediaElement::didFinishInsertingNode() so this is no longer happening.