Bug 101124
| Summary: | LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Layout and Rendering | Assignee: | Glenn Adams <glenn> |
| Status: | NEW | ||
| Severity: | Normal | CC: | glenn, seikwon.kim |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 89235 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool
bug 89235 introduces a somewhat odd system of encoding the loose/strict breaking variant as part of the locale string which is used by the pool as a key.
It would be cleaner to have ICU-agnostic logic to parse out the locale and break variant and then pass them around as class instead of encoded in the string.
I believe this would require either defining a HashTraits for the new class, or using std::pair<AtomicString, LineBreakIteratorMode> which I believe already has generic HashTraits to do the right thing. :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |