Bug 100548

Summary: [CSS Shaders] Extract the CustomFilterParameterList to its own file
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dino, gyuyoung.kim, macpherson, menard, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100533    
Attachments:
Description Flags
Patch V1
webkit-ews: commit-queue-
Patch V2
webkit-ews: commit-queue-
Patch V3
dino: review+, eflews.bot: commit-queue-
Patch for landing none

Alexandru Chiculita
Reported 2012-10-26 11:52:44 PDT
CustomFilterParameterList is defined as a typedef in the header of CustomFilterOperation. We will reuse the CustomFilterParameterList in different other places, so extract that to its own file.
Attachments
Patch V1 (22.12 KB, patch)
2012-10-26 13:34 PDT, Alexandru Chiculita 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch V2 (22.97 KB, patch)
2012-10-26 15:03 PDT, Alexandru Chiculita 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch V3 (23.06 KB, patch)
2012-10-26 15:20 PDT, Alexandru Chiculita 		dino: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (23.07 KB, patch)
2012-10-29 09:22 PDT, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1 2012-10-26 13:34:00 PDT
Created attachment 170993 [details] Patch V1
Early Warning System Bot
Comment 2 2012-10-26 13:42:33 PDT
Comment on attachment 170993 [details] Patch V1 Attachment 170993 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14610169
Alexandru Chiculita
Comment 3 2012-10-26 15:03:58 PDT
Created attachment 171025 [details] Patch V2
WebKit Review Bot
Comment 4 2012-10-26 15:09:36 PDT
Attachment 171025 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:43: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:44: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 5 2012-10-26 15:12:32 PDT
Comment on attachment 171025 [details] Patch V2 Attachment 171025 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14593824
Early Warning System Bot
Comment 6 2012-10-26 15:17:19 PDT
Comment on attachment 171025 [details] Patch V2 Attachment 171025 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14617145
Alexandru Chiculita
Comment 7 2012-10-26 15:20:57 PDT
Created attachment 171026 [details] Patch V3
Max Vujovic
Comment 8 2012-10-26 16:58:28 PDT
Comment on attachment 171026 [details] Patch V3 Looks good, Alex. View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review > Source/WebCore/platform/graphics/filters/CustomFilterParameterList.cpp:49 > +bool CustomFilterParameterList::operator==(const CustomFilterParameterList& other) const Nice. An operator== looks much better than customFilterParametersEqual(...). > Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:45 > + explicit CustomFilterParameterList(size_t); Nice use of explicit.
EFL EWS Bot
Comment 9 2012-10-26 16:59:43 PDT
Comment on attachment 171026 [details] Patch V3 Attachment 171026 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14608279
Dean Jackson
Comment 10 2012-10-29 07:07:02 PDT
Comment on attachment 171026 [details] Patch V3 I like this patch. Not sure why EFL couldn't find the new file, but assuming that works itself out, I'm happy.
Raphael Kubo da Costa (:rakuco)
Comment 11 2012-10-29 07:14:03 PDT
Comment on attachment 171026 [details] Patch V3 View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review > Source/WebCore/CMakeLists.txt:1914 > + platform/graphics/filters/CustomFilterParameter.cpp The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp.
Dean Jackson
Comment 12 2012-10-29 08:13:29 PDT
(In reply to comment #11) > (From update of attachment 171026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review > > > Source/WebCore/CMakeLists.txt:1914 > > + platform/graphics/filters/CustomFilterParameter.cpp > > The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp. Ah, thanks! No need to r- then because it is an easy fix.
Alexandru Chiculita
Comment 13 2012-10-29 08:42:30 PDT
(In reply to comment #12) > (In reply to comment #11) > > (From update of attachment 171026 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review > > > > > Source/WebCore/CMakeLists.txt:1914 > > > + platform/graphics/filters/CustomFilterParameter.cpp > > > > The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp. > > Ah, thanks! No need to r- then because it is an easy fix. Thanks, Dean! Sorry about the naming, it's the evil copy-paste :)
Alexandru Chiculita
Comment 14 2012-10-29 09:22:37 PDT
Created attachment 171258 [details] Patch for landing
WebKit Review Bot
Comment 15 2012-10-29 09:50:25 PDT
Comment on attachment 171258 [details] Patch for landing Clearing flags on attachment: 171258 Committed r132808: <http://trac.webkit.org/changeset/132808>
WebKit Review Bot
Comment 16 2012-10-29 09:50:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.