99919 2012-10-20 19:35:43 -0700 BasicShapePolygon::path takes width instead of height for boundary calculation 2012-10-23 13:17:50 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95389 1 krit krit donggwan.kim eric webkit.review.bot oldest_to_newest 747029 0 krit 2012-10-20 19:35:43 -0700 BasicShapePolygon::path takes width instead of height for calculation. path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()) + boundingBox.x(), floatValueForLength(m_values.at(1), boundingBox.width()) + boundingBox.y())); for (size_t i = 2; i < length; i = i + 2) { path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()) + boundingBox.x(), floatValueForLength(m_values.at(i + 1), boundingBox.width()) + boundingBox.y())); Realized it on writing further tests. Will come up with a patch soon. 747977 1 170003 krit 2012-10-22 15:39:10 -0700 Created attachment 170003 Patch 748153 2 170003 darin 2012-10-22 18:19:18 -0700 Comment on attachment 170003 Patch The test seems a little too oblique to me. I’d put some explanatory text in it. Since it’s a ref test, the text would not make it any more prone to failure on different platforms and could make it self documenting. 748891 3 krit 2012-10-23 13:17:50 -0700 Committed r132257: <http://trac.webkit.org/changeset/132257> 170003 2012-10-22 15:39:10 -0700 2012-10-22 18:19:18 -0700 Patch bug-99919-20121022153748.patch text/plain 4086 krit U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNiOTI2NDkyYTcwNzQz Y2EzNGVmMzAzMDY1ODZiZDU0NjNlNmI4OS4uZDQ1OGY1YTY0MzhmYzM5MWFkZjhkYThhYjFlNDYy NGI3NDQwMTUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTIyICBEaXJr IFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQmFzaWNTaGFwZVBvbHlnb246 OnBhdGggdGFrZXMgd2lkdGggaW5zdGVhZCBvZiBoZWlnaHQgZm9yIGJvdW5kYXJ5IGNhbGN1bGF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTkx OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSAn eScgcGFyYW1ldGVycyBvZiBwb2x5Z29uIHdlcmUgY2FsY3VsYXRlZCBieSB0aGUgd2l0aCBvZiB0 aGUgYm91bmRpbmcgYm94IG9mIHRoZSBvYmplY3QuCisgICAgICAgIFRoaXMgY2F1c2VkIHByb2Js ZW1zIG9uIHBlcmNlbnRhZ2UgdmFsdWVzIGZvciBwb2ludCBwb3NpdGlvbnMuIAorICAgICAgICBD aGFuZ2VkIGl0IHRvIHRoZSBoZWlnaHQgb2YgdGhlIGJvdW5kaW5nIGJveC4KKworICAgICAgICBU ZXN0OiBjc3MzL21hc2tpbmcvY2xpcC1wYXRoLXBvbHlnb24tcGVyY2VudGFnZS5odG1sCisKKyAg ICAgICAgKiByZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QmFzaWNTaGFwZVBvbHlnb246OnBhdGgpOgorCiAyMDEyLTEwLTIyICBNaWtlIFdlc3QgIDxt a3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgJ2ltYWdlL3BqcGVnJyBzaG91bGQgYmUgdHJl YXRlZCBhcyBhbiBpbWFnZSBieSBXZWIgSW5zcGVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5jcHAKaW5kZXggOWIxMjQ1ZjY2NmE5ZTA0NjMyYTZi NGNiMmJhMjRlNTZmZmFiMWEzMC4uMjljYTQ1ZDAxZTY5ODI0MTIzNDk0MDNlMDMyZDE1ZjQ4NjEw YjFlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hh cGVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMu Y3BwCkBAIC04MywxMCArODMsMTAgQEAgdm9pZCBCYXNpY1NoYXBlUG9seWdvbjo6cGF0aChQYXRo JiBwYXRoLCBjb25zdCBGbG9hdFJlY3QmIGJvdW5kaW5nQm94KQogICAgICAgICByZXR1cm47CiAK ICAgICBwYXRoLm1vdmVUbyhGbG9hdFBvaW50KGZsb2F0VmFsdWVGb3JMZW5ndGgobV92YWx1ZXMu YXQoMCksIGJvdW5kaW5nQm94LndpZHRoKCkpICsgYm91bmRpbmdCb3gueCgpLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aChtX3ZhbHVlcy5hdCgxKSwgYm91 bmRpbmdCb3gud2lkdGgoKSkgKyBib3VuZGluZ0JveC55KCkpKTsKKyAgICAgICAgZmxvYXRWYWx1 ZUZvckxlbmd0aChtX3ZhbHVlcy5hdCgxKSwgYm91bmRpbmdCb3guaGVpZ2h0KCkpICsgYm91bmRp bmdCb3gueSgpKSk7CiAgICAgZm9yIChzaXplX3QgaSA9IDI7IGkgPCBsZW5ndGg7IGkgPSBpICsg MikgewogICAgICAgICBwYXRoLmFkZExpbmVUbyhGbG9hdFBvaW50KGZsb2F0VmFsdWVGb3JMZW5n dGgobV92YWx1ZXMuYXQoaSksIGJvdW5kaW5nQm94LndpZHRoKCkpICsgYm91bmRpbmdCb3gueCgp LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0VmFsdWVGb3JMZW5ndGgo bV92YWx1ZXMuYXQoaSArIDEpLCBib3VuZGluZ0JveC53aWR0aCgpKSArIGJvdW5kaW5nQm94Lnko KSkpOworICAgICAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aChtX3ZhbHVlcy5hdChpICsgMSks IGJvdW5kaW5nQm94LmhlaWdodCgpKSArIGJvdW5kaW5nQm94LnkoKSkpOwogICAgIH0KICAgICBw YXRoLmNsb3NlU3VicGF0aCgpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFlYzkwZWVkZGIzZWU5Y2U3ZjQ5NWNmNjdk ZmNjNzI2ZjE5ZjU5ZTMuLjVmMWE2OWE0YmJmOTJmNGU5NTQ4YThlZjJiNjk3YzQxZjEzMWM4YjQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMC0yMiAgRGlyayBTY2h1bHplICA8a3JpdEB3 ZWJraXQub3JnPgorCisgICAgICAgIEJhc2ljU2hhcGVQb2x5Z29uOjpwYXRoIHRha2VzIHdpZHRo IGluc3RlYWQgb2YgaGVpZ2h0IGZvciBib3VuZGFyeSBjYWxjdWxhdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk5MTkKKworICAgICAgICBUZXN0 IHRoYXQgdGhlIGNvcnJlY3QgcmVsYXRpb24gaXMgdXNlZCBmb3IgY2FsY3VsYXRpbmcgcG9pbnQg cG9zaXRpb24gb2YgYW4gcG9seWdvbi4KKworICAgICAgICAqIGNzczMvbWFza2luZy9jbGlwLXBh dGgtcG9seWdvbi1wZXJjZW50YWdlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNz czMvbWFza2luZy9jbGlwLXBhdGgtcG9seWdvbi1wZXJjZW50YWdlLmh0bWw6IEFkZGVkLgorCiAy MDEyLTEwLTIyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFA aW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFJlYmFzZWxpbmUgcGl4ZWwgZXhwZWN0YXRpb25z IGFmdGVyIHIxMzE5NDEgYW5kIHIxMzE5OTEsIHBhcnQgNS4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2NzczMvbWFza2luZy9jbGlwLXBhdGgtcG9seWdvbi1wZXJjZW50YWdlLWV4cGVjdGVkLmh0 bWwgYi9MYXlvdXRUZXN0cy9jc3MzL21hc2tpbmcvY2xpcC1wYXRoLXBvbHlnb24tcGVyY2VudGFn ZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU1NTRmMzE3MGVlZWRjNGFjMGZiMGI0YzA2NGUz MmNhMDViYTJlYzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL21hc2tpbmcv Y2xpcC1wYXRoLXBvbHlnb24tcGVyY2VudGFnZS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNiBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorICAgIDxkaXYgc3R5bGU9IndpZHRo OiAxNTBweDsgaGVpZ2h0OiAxMDBweDsgYm9yZGVyOiBzb2xpZCB3aGl0ZSA1MHB4OyBiYWNrZ3Jv dW5kLWNvbG9yOiBncmVlbjsiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUg YXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvbWFza2luZy9jbGlw LXBhdGgtcG9seWdvbi1wZXJjZW50YWdlLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL21hc2tpbmcv Y2xpcC1wYXRoLXBvbHlnb24tcGVyY2VudGFnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYxOTg0NTgzNTE0 NjFlZTNmNWNkY2Q1NzBmMzA5MDMzOTQ1NWJkODcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9jc3MzL21hc2tpbmcvY2xpcC1wYXRoLXBvbHlnb24tcGVyY2VudGFnZS5odG1sCkBAIC0w LDAgKzEsNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorICAgIDxkaXYgc3R5 bGU9Im1hcmdpbjowOyB3aWR0aDogMTUwcHg7IGhlaWdodDogMTAwcHg7IGJvcmRlcjogc29saWQg cmVkIDUwcHg7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyAtd2Via2l0LWNsaXAtcGF0aDogcG9s eWdvbigyMCUgNTBweCwgODAlIDI1JSwgODAlIDc1JSwgMjAlIDc1JSkiPjwvZGl2PgorPC9ib2R5 PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK